From: Peter Zijlstra <peterz@infradead.org>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: Yong Zhang <yong.zhang0@gmail.com>,
Hillf Danton <dhillf@gmail.com>,
LKML <linux-kernel@vger.kernel.org>,
Mike Galbraith <efault@gmx.de>, Ingo Molnar <mingo@elte.hu>
Subject: Re: [PATCH] sched: remove resetting exec_start in put_prev_task_rt()
Date: Fri, 10 Jun 2011 12:19:06 +0200 [thread overview]
Message-ID: <1307701146.3941.113.camel@twins> (raw)
In-Reply-To: <1307673703.9218.42.camel@gandalf.stny.rr.com>
On Thu, 2011-06-09 at 22:41 -0400, Steven Rostedt wrote:
> On Fri, 2011-06-10 at 10:38 +0800, Yong Zhang wrote:
> > On Thu, Jun 9, 2011 at 8:34 PM, Steven Rostedt <rostedt@goodmis.org> wrote:
> > > I disagree. Yes the exec_start is reset there, but I like the fact that
> > > it's 0 when not running.
> >
> > Actually this depends on how we look at the code:
> > if we set exec_start to 0 explicitly, as you said the code is more direct and
> > readable.
> > if we don't set exec_start to 0, we can save one instruction though
> > it's minor.
> >
> > I have no strong opinion on either of them :)
>
> I don't have any real strong opinion on this either, so I'll just let
> Peter decide :)
Yay! So IFF its correct (I didn't check) then sure it saves a whole
store :-), I don't think sched_fair clears exec_start on de-schedule
either.
next prev parent reply other threads:[~2011-06-10 10:19 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-01 14:03 [PATCH] sched: remove resetting exec_start in put_prev_task_rt() Hillf Danton
2011-06-01 14:22 ` Steven Rostedt
2011-06-02 8:04 ` Yong Zhang
2011-06-04 4:26 ` Hillf Danton
2011-06-09 12:34 ` Steven Rostedt
2011-06-10 2:38 ` Yong Zhang
2011-06-10 2:41 ` Steven Rostedt
2011-06-10 10:19 ` Peter Zijlstra [this message]
2011-06-10 14:48 ` Hillf Danton
2011-06-10 14:58 ` Steven Rostedt
2011-06-10 15:12 ` Hillf Danton
2011-08-14 16:03 ` [tip:sched/core] sched: Remove " tip-bot for Hillf Danton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1307701146.3941.113.camel@twins \
--to=peterz@infradead.org \
--cc=dhillf@gmail.com \
--cc=efault@gmx.de \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=rostedt@goodmis.org \
--cc=yong.zhang0@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.