Re: [PATCH 1/1] dl2k: EEPROM CRC calculation wrong endianess on bigendian machine

[Ben Hutchings <bhutchings@solarflare.com>]

On Fri, 2011-06-10 at 15:16 +0200, Daniel Hellstrom wrote:
> Signed-off-by: Daniel Hellstrom <daniel@gaisler.com>
> ---
>  drivers/net/dl2k.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/net/dl2k.c b/drivers/net/dl2k.c
> index c445457..4bbbd7b 100644
> --- a/drivers/net/dl2k.c
> +++ b/drivers/net/dl2k.c
> @@ -346,7 +346,7 @@ parse_eeprom (struct net_device *dev)
>  	if (np->pdev->vendor == PCI_VENDOR_ID_DLINK) {	/* D-Link Only */
>  		/* Check CRC */
>  		crc = ~ether_crc_le (256 - 4, sromdata);
> -		if (psrom->crc != crc) {
> +		if (psrom->crc != cpu_to_le32(crc)) {q

You still have a rogue 'q' there.

Ben.

>  			printk (KERN_ERR "%s: EEPROM data CRC error.\n",
>  					dev->name);
>  			return -1;

-- 
Ben Hutchings, Senior Software Engineer, Solarflare
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.