From: Phil Blundell <pb@pbcl.net>
To: Patches and discussions about the oe-core layer
<openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH 2/2] sysklogd.inc: Check for package-management in IMAGE_FEATURES
Date: Fri, 10 Jun 2011 15:17:13 +0100 [thread overview]
Message-ID: <1307715433.25285.18.camel@phil-desktop> (raw)
In-Reply-To: <1307667467-467-2-git-send-email-raj.khem@gmail.com>
On Thu, 2011-06-09 at 17:57 -0700, Khem Raj wrote:
> -RDEPENDS_${PN}_append = " ${@base_conditional("ONLINE_PACKAGE_MANAGEMENT", "none", "", "update-rc.d", d)}"
> +RDEPENDS_${PN}_append = " ${@oe.utils.contains("IMAGE_FEATURES", "package-management", "update-rc.d", "", d)}"
This sort of thing shouldn't be necessary in oe-core. See previous
discussions between me and Richard as to why IMAGE_FEATURES is not the
right thing, and code in package_ipk.bbclass which ought to be taking
care of it. If you're using a different package manager then it should
be fairly straightforward to adapt that logic to suit.
You're right though the the reference to O_P_M is clearly wrong and
should be removed. I'm not quite sure how that got in there in the
first place; must have been some oversight during patch review I guess.
p.
next prev parent reply other threads:[~2011-06-10 14:20 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-10 0:57 [PATCH 1/2] openssh_5.8p2.bb: Update SRC_URI checksums Khem Raj
2011-06-10 0:57 ` [PATCH 2/2] sysklogd.inc: Check for package-management in IMAGE_FEATURES Khem Raj
2011-06-10 6:39 ` Koen Kooi
2011-06-10 14:17 ` Phil Blundell [this message]
2011-06-10 1:18 ` [PATCH 1/2] openssh_5.8p2.bb: Update SRC_URI checksums Saul Wold
2011-06-10 2:44 ` Khem Raj
2011-06-10 4:38 ` Saul Wold
2011-06-10 5:36 ` Khem Raj
2011-06-10 5:52 ` Saul Wold
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1307715433.25285.18.camel@phil-desktop \
--to=pb@pbcl.net \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.