All of lore.kernel.org
 help / color / mirror / Atom feed
From: Rakib Mullick <rakib.mullick@gmail.com>
To: mingo@elte.hu
Cc: hpa@zytor.com, tglx@linutronix.de, luto@mit.edu, x86@kernel.org,
	linux-kernel@vger.kernel.org
Subject: [PATCH] x86, vsyscall: Fix build warning in vsyscall_64.c
Date: Sat, 11 Jun 2011 13:31:04 +0600	[thread overview]
Message-ID: <1307777464.25182.3.camel@localhost.localdomain> (raw)

Due to commit 5cec93c216db77 (x86-64: Emulate legacy vsyscalls), we get the following warning:

   arch/x86/kernel/vsyscall_64.c: In function ‘do_emulate_vsyscall’:
   arch/x86/kernel/vsyscall_64.c:111:7: warning: ‘ret’ may be used uninitialized in this function

The uninitialized value of 'ret' maybe gets assigned to regs->ax. So, initialize it with -EINVAL.

Signed-off-by: Rakib Mullick <rakib.mullick@gmail.com>
---

diff --git a/arch/x86/kernel/vsyscall_64.c b/arch/x86/kernel/vsyscall_64.c
index 10cd8ac..180c56d 100644
--- a/arch/x86/kernel/vsyscall_64.c
+++ b/arch/x86/kernel/vsyscall_64.c
@@ -108,7 +108,7 @@ void dotraplinkage do_emulate_vsyscall(struct pt_regs *regs, long error_code)
 	struct task_struct *tsk;
 	unsigned long caller;
 	int vsyscall_nr;
-	long ret;
+	long ret = -EINVAL;
 
 	/* Kernel code must never get here. */
 	BUG_ON(!user_mode(regs));
@@ -163,7 +163,7 @@ void dotraplinkage do_emulate_vsyscall(struct pt_regs *regs, long error_code)
 		BUG();
 	}
 
-	if (ret == -EFAULT) {
+	if (ret == -EFAULT || ret == -EINVAL) {
 		/*
 		 * Bad news -- userspace fed a bad pointer to a vsyscall.
 		 *



             reply	other threads:[~2011-06-11  7:31 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-06-11  7:31 Rakib Mullick [this message]
2011-06-11 11:01 ` [PATCH] x86, vsyscall: Fix build warning in vsyscall_64.c Andrew Lutomirski
2011-06-12  5:12   ` Rakib Mullick
2011-06-13  2:52     ` Andrew Lutomirski
2011-06-13  4:54       ` Rakib Mullick
2011-06-13  8:45         ` Rakib Mullick
2011-06-13 18:06           ` Andrew Lutomirski
2011-06-14 17:43             ` Rakib Mullick
2011-06-14 18:03               ` Andy Lutomirski
2011-06-14 21:16                 ` Ingo Molnar
2011-06-14 21:24                   ` Linus Torvalds
2011-06-14 21:31                     ` Ingo Molnar
2011-06-14 21:33                       ` Andrew Lutomirski
2011-06-15  5:59                         ` Rakib Mullick
2011-06-15  7:25                           ` Ingo Molnar
2011-06-15 18:49                             ` Linus Torvalds
2011-06-15 19:24                               ` Andrew Lutomirski
2011-06-15 19:32                                 ` Linus Torvalds
2011-06-15 19:51                                   ` Andrew Lutomirski
2011-06-13  9:29   ` Ingo Molnar
2011-06-13 13:03     ` Andrew Lutomirski
2011-06-13 14:14       ` Ingo Molnar
2011-06-13 14:18         ` Andrew Lutomirski
2011-06-13 17:05           ` Rakib Mullick
2011-06-13 17:06             ` Andrew Lutomirski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1307777464.25182.3.camel@localhost.localdomain \
    --to=rakib.mullick@gmail.com \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=luto@mit.edu \
    --cc=mingo@elte.hu \
    --cc=tglx@linutronix.de \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.