Re: [PATCH 0/2] meta-intel: add bbappends for systemtap

[Tom Zanussi <tom.zanussi@intel.com>]

On Mon, 2011-06-13 at 11:32 -0700, Darren Hart wrote:
> On 06/13/2011 07:32 AM, tom.zanussi@intel.com wrote:
> > From: Tom Zanussi <tom.zanussi@intel.com>
> > 
> > Removing any old references to systemtap from meta means we need to add
> > it here.  It also adds systemtap support for the other, previously
> > uncovered meta-intel bsps.
> 
> Wouldn't it make more sense to add systemtap to and image recipe, either
> a new recipe or a bbappend? Also, it seems to me that RRECOMMENDS would
> make more sense than RDEPENDS - as it isn't required for boot.
> 

Hmm, not following you here - why would I want a new image recipe for
systemtap?

Systemtap fits in with the other profiling tools in the
task-core-tools-profile as far as I can see; this patch essentially adds
systemtap to that list, but since it won't run on half the architectures
we support, it can't be simply added to the recipe but needs to be
appended for each machine (well, that may change when I switch to
COMPATIBLE_HOST as pointed out by a couple people, but that was the
reason behind the current appends).

And, yeah, maybe RRECOMMENDs makes more sense here, will think about
changing that on the respin.

Thanks,

Tom

> --
> Darren
> 
> > 
> > The following changes since commit 01d1a545477cbc1b2a1da5b66edb52fd9e783206:
> >   Tom Zanussi (1):
> >         meta-intel: update kernel SRCREVs
> > 
> > are available in the git repository at:
> > 
> >   git://git.yoctoproject.org/meta-intel.git tzanussi/systemtap-update
> >   http://git.yoctoproject.org/cgit.cgi//log/?h=tzanussi/systemtap-update
> > 
> > Tom Zanussi (2):
> >   meta-emenlow: add systemtap bbappend
> >   meta-intel: add systemtap bbappends
> > 
> >  .../recipes-core/tasks/task-core-tools.bbappend    |    3 +++
> >  .../systemtap/systemtap_git.bbappend               |    1 +
> >  .../systemtap/systemtap_git.bbappend               |    1 +
> >  .../recipes-core/tasks/task-core-tools.bbappend    |    2 ++
> >  .../systemtap/systemtap_git.bbappend               |    1 +
> >  .../recipes-core/tasks/task-core-tools.bbappend    |    2 ++
> >  .../systemtap/systemtap_git.bbappend               |    1 +
> >  .../recipes-core/tasks/task-core-tools.bbappend    |    2 ++
> >  .../systemtap/systemtap_git.bbappend               |    1 +
> >  .../recipes-core/tasks/task-core-tools.bbappend    |    2 ++
> >  .../systemtap/systemtap_git.bbappend               |    1 +
> >  11 files changed, 17 insertions(+), 0 deletions(-)
> >  create mode 100644 meta-crownbay/recipes-core/tasks/task-core-tools.bbappend
> >  create mode 100644 meta-crownbay/recipes-kernel/systemtap/systemtap_git.bbappend
> >  create mode 100644 meta-emenlow/recipes-kernel/systemtap/systemtap_git.bbappend
> >  create mode 100644 meta-fishriver/recipes-core/tasks/task-core-tools.bbappend
> >  create mode 100644 meta-fishriver/recipes-kernel/systemtap/systemtap_git.bbappend
> >  create mode 100644 meta-jasperforest/recipes-core/tasks/task-core-tools.bbappend
> >  create mode 100644 meta-jasperforest/recipes-kernel/systemtap/systemtap_git.bbappend
> >  create mode 100644 meta-n450/recipes-core/tasks/task-core-tools.bbappend
> >  create mode 100644 meta-n450/recipes-kernel/systemtap/systemtap_git.bbappend
> >  create mode 100644 meta-sugarbay/recipes-core/tasks/task-core-tools.bbappend
> >  create mode 100644 meta-sugarbay/recipes-kernel/systemtap/systemtap_git.bbappend
> > 
> > _______________________________________________
> > yocto mailing list
> > yocto@yoctoproject.org
> > https://lists.yoctoproject.org/listinfo/yocto
>