From: Peter Zijlstra <peterz@infradead.org>
To: Glauber Costa <glommer@redhat.com>
Cc: kvm@vger.kernel.org, linux-kernel@vger.kernel.org,
Rik van Riel <riel@redhat.com>,
Jeremy Fitzhardinge <jeremy.fitzhardinge@citrix.com>,
Avi Kivity <avi@redhat.com>,
Anthony Liguori <aliguori@us.ibm.com>,
Eric B Munson <emunson@mgebm.net>
Subject: Re: [PATCH 5/7] KVM-GST: KVM Steal time accounting
Date: Wed, 15 Jun 2011 11:28:22 +0200 [thread overview]
Message-ID: <1308130102.15315.17.camel@twins> (raw)
In-Reply-To: <4DF805F3.4030603@redhat.com>
On Tue, 2011-06-14 at 22:08 -0300, Glauber Costa wrote:
> >> + while (steal> TICK_NSEC) {
> >
> > /* really, if we wanted a division we'd have
> written one */
> > asm("" : "+rm" (steal));
>
> Out of curiosity, have we seen any compiler de-optimize it to a
> division, or are you just being careful ?
>
> >> + steal -= TICK_NSEC;
> >> + st++;
> >> + }
No that really happened a number of times, there's one in
sched_avg_period() that actually triggered and __iter_div_u64_rem() that
started it all iirc.
next prev parent reply other threads:[~2011-06-15 9:28 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-13 23:31 [PATCH 0/7] KVM steal time implementation Glauber Costa
2011-06-13 23:31 ` [PATCH 1/7] KVM-HDR Add constant to represent KVM MSRs enabled bit Glauber Costa
2011-06-14 0:59 ` Rik van Riel
2011-06-14 1:18 ` Eric B Munson
2011-06-13 23:31 ` [PATCH 2/7] KVM-HDR: KVM Steal time implementation Glauber Costa
2011-06-14 1:19 ` Eric B Munson
2011-06-14 1:33 ` Rik van Riel
2011-06-13 23:31 ` [PATCH 3/7] KVM-HV: " Glauber Costa
2011-06-14 1:20 ` Eric B Munson
2011-06-14 7:45 ` Gleb Natapov
2011-06-15 1:01 ` Glauber Costa
2011-06-15 3:09 ` Glauber Costa
2011-06-15 9:09 ` Gleb Natapov
2011-06-16 3:31 ` Glauber Costa
2011-06-16 11:27 ` Gleb Natapov
2011-06-16 12:11 ` Glauber Costa
2011-06-16 12:21 ` Gleb Natapov
2011-06-16 12:24 ` Glauber Costa
2011-06-19 12:35 ` Avi Kivity
2011-06-19 12:59 ` Gleb Natapov
2011-06-19 13:02 ` Avi Kivity
2011-06-20 7:21 ` Gleb Natapov
2011-06-20 8:02 ` Avi Kivity
2011-06-20 12:42 ` Glauber Costa
2011-06-20 13:38 ` Gleb Natapov
2011-06-14 12:20 ` Rik van Riel
2011-06-13 23:31 ` [PATCH 4/7] KVM-GST: Add a pv_ops stub for steal time Glauber Costa
2011-06-14 1:20 ` Eric B Munson
2011-06-14 13:23 ` Rik van Riel
2011-06-13 23:31 ` [PATCH 5/7] KVM-GST: KVM Steal time accounting Glauber Costa
2011-06-14 1:21 ` Eric B Munson
2011-06-14 10:10 ` Peter Zijlstra
2011-06-15 1:08 ` Glauber Costa
2011-06-15 9:28 ` Peter Zijlstra [this message]
2011-06-13 23:31 ` [PATCH 6/7] KVM-GST: adjust scheduler cpu power Glauber Costa
2011-06-14 1:21 ` Eric B Munson
2011-06-14 2:47 ` Asias He
2011-06-14 10:42 ` Peter Zijlstra
2011-06-15 1:26 ` Glauber Costa
2011-06-20 14:41 ` Peter Zijlstra
2011-06-13 23:31 ` [PATCH 7/7] KVM-GST: KVM Steal time registration Glauber Costa
2011-06-14 1:21 ` Eric B Munson
2011-06-14 8:06 ` Gleb Natapov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1308130102.15315.17.camel@twins \
--to=peterz@infradead.org \
--cc=aliguori@us.ibm.com \
--cc=avi@redhat.com \
--cc=emunson@mgebm.net \
--cc=glommer@redhat.com \
--cc=jeremy.fitzhardinge@citrix.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=riel@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.