All of lore.kernel.org
 help / color / mirror / Atom feed
From: Paul Eggleton <paul.eggleton@linux.intel.com>
To: openembedded-devel@lists.openembedded.org
Subject: [PATCH] classes/native*.bbclass: fix error during parse with bitbake master
Date: Wed, 22 Jun 2011 10:13:14 +0100	[thread overview]
Message-ID: <1308733994-3571-1-git-send-email-paul.eggleton@linux.intel.com> (raw)

Fixes "AttributeError: 'NoneType' object has no attribute 'split'" during
parsing with bitbake master. We should not be calling explode_deps with
None as the argument, so check for that before calling it.

Signed-off-by: Paul Eggleton <paul.eggleton@linux.intel.com>
---
 classes/native.bbclass    |    5 ++++-
 classes/nativesdk.bbclass |    5 ++++-
 2 files changed, 8 insertions(+), 2 deletions(-)

diff --git a/classes/native.bbclass b/classes/native.bbclass
index 1e7a6ec..e9d48a3 100644
--- a/classes/native.bbclass
+++ b/classes/native.bbclass
@@ -116,7 +116,10 @@ python __anonymous () {
     if "native" in (bb.data.getVar('BBCLASSEXTEND', d, True) or ""):
         pn = bb.data.getVar("PN", d, True)
         depends = bb.data.getVar("DEPENDS_virtclass-native", d, True)
-        deps = bb.utils.explode_deps(depends)
+        if depends:
+            deps = bb.utils.explode_deps(depends)
+        else:
+            deps = []
         newdeps = []
         for dep in deps:
             if dep.endswith("-cross"):
diff --git a/classes/nativesdk.bbclass b/classes/nativesdk.bbclass
index 6689399..7a8f385 100644
--- a/classes/nativesdk.bbclass
+++ b/classes/nativesdk.bbclass
@@ -59,7 +59,10 @@ OVERRIDES =. "virtclass-nativesdk:"
 python __anonymous () {
     pn = bb.data.getVar("PN", d, True)
     depends = bb.data.getVar("DEPENDS_virtclass-nativesdk", d, True)
-    deps = bb.utils.explode_deps(depends)
+    if depends:
+        deps = bb.utils.explode_deps(depends)
+    else:
+        deps = []
     newdeps = []
     for dep in deps:
         if dep.endswith("-native") or dep.endswith("-cross"):
-- 
1.7.4.1




             reply	other threads:[~2011-06-22  9:17 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-06-22  9:13 Paul Eggleton [this message]
2011-06-22  9:27 ` [PATCH] classes/native*.bbclass: fix error during parse with bitbake master Koen Kooi
2011-06-22  9:48 ` Phil Blundell
2011-06-22 10:18   ` [PATCH v2] " Paul Eggleton
2011-06-23 23:26     ` Andrea Adami

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1308733994-3571-1-git-send-email-paul.eggleton@linux.intel.com \
    --to=paul.eggleton@linux.intel.com \
    --cc=openembedded-devel@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.