All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Brian Norris" <computersforpeace@gmail.com>
To: "Artem Bityutskiy" <dedekind1@gmail.com>
Cc: David Woodhouse <dwmw2@infradead.org>,
	Brian Norris <computersforpeace@gmail.com>,
	linux-mtd@lists.infradead.org,
	Mike Frysinger <vapier.adi@gmail.com>
Subject: [PATCH v3 2/7] nanddump: remove --skipbad, leaving --bb=skipbad
Date: Wed, 22 Jun 2011 09:49:18 -0700	[thread overview]
Message-ID: <1308761363-16512-3-git-send-email-computersforpeace@gmail.com> (raw)
In-Reply-To: <BANLkTi=-25MExYfuB-ANK4ceh3gWy+BqCg@mail.gmail.com>

We are moving to unify bad block handling methods under the --bb=METHOD
option. Since --skipbad has not been included in a mtd-utils release yet,
we can safely replace it without a deprecation and phase-out period.

Signed-off-by: Brian Norris <computersforpeace@gmail.com>
---
 nanddump.c |   13 +------------
 1 files changed, 1 insertions(+), 12 deletions(-)

diff --git a/nanddump.c b/nanddump.c
index 08f8964..d2e2e8f 100644
--- a/nanddump.c
+++ b/nanddump.c
@@ -51,7 +51,6 @@ static void display_help(void)
 "-b         --omitbad            Omit bad blocks from the dump\n"
 "-c         --canonicalprint     Print canonical Hex+ASCII dump\n"
 "-f file    --file=file          Dump to file\n"
-"-k         --skipbad            Skip over bad blocks (see below)\n"
 "-l length  --length=length      Length\n"
 "-n         --noecc              Read without error correction\n"
 "-N         --noskipbad          Read without bad block skipping\n"
@@ -111,7 +110,7 @@ static void process_options(int argc, char * const argv[])
 
 	for (;;) {
 		int option_index = 0;
-		static const char *short_options = "bs:f:l:opqnNcak";
+		static const char *short_options = "bs:f:l:opqnNca";
 		static const struct option long_options[] = {
 			{"help", no_argument, 0, 0},
 			{"version", no_argument, 0, 0},
@@ -126,7 +125,6 @@ static void process_options(int argc, char * const argv[])
 			{"length", required_argument, 0, 'l'},
 			{"noecc", no_argument, 0, 'n'},
 			{"noskipbad", no_argument, 0, 'N'},
-			{"skipbad", no_argument, 0, 'k'},
 			{"quiet", no_argument, 0, 'q'},
 			{0, 0, 0, 0},
 		};
@@ -207,15 +205,6 @@ static void process_options(int argc, char * const argv[])
 					error++;
 				}
 				break;
-			case 'k':
-				/* Check if bb_method was already set explicitly */
-				if (bb_default) {
-					bb_default = false;
-					bb_method = skipbad;
-				} else {
-					error++;
-				}
-				break;
 			case '?':
 				error++;
 				break;
-- 
1.7.0.4

  parent reply	other threads:[~2011-06-22 16:51 UTC|newest]

Thread overview: 39+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-06-21 15:46 [PATCH v2 0/7] new nanddump defaults Brian Norris
2011-06-21 15:46 ` [PATCH v2 1/7] nanddump: add --bb=METHOD option Brian Norris
2011-06-21 15:46 ` [PATCH v2 2/7] nanddump: remove --skipbad, leaving --bb=skipbad Brian Norris
2011-06-21 15:46 ` [PATCH v2 3/7] nanddump: deprecation messages for old BB options Brian Norris
2011-06-21 19:38   ` Mike Frysinger
2011-06-21 15:46 ` [PATCH v2 4/7] nanddump: warn about new default BB handling Brian Norris
2011-06-21 19:37   ` Mike Frysinger
2011-06-21 15:46 ` [PATCH v2 5/7] feature-removal-schedule: describe nanddump changes Brian Norris
2011-06-21 15:46 ` [PATCH v2 6/7] nanddump: add --oob option Brian Norris
2011-06-21 15:46 ` [PATCH v2 7/7] nanddump: document, warn about future default --omitoob Brian Norris
2011-06-21 19:39   ` Mike Frysinger
2011-06-21 19:40 ` [PATCH v2 0/7] new nanddump defaults Mike Frysinger
2011-06-21 22:36   ` Brian Norris
2011-06-22 16:49     ` [PATCH v3 0/7] prepare new nanddump options, defaults Brian Norris
2011-06-23 15:02       ` Artem Bityutskiy
2011-06-23 15:04         ` Artem Bityutskiy
2011-06-23 15:52           ` Mike Frysinger
2011-06-23 23:00             ` Brian Norris
2011-06-23 23:14               ` Mike Frysinger
2011-06-23 23:27                 ` Brian Norris
2011-06-23 23:36                   ` Mike Frysinger
2011-06-23 23:40                     ` Brian Norris
2011-06-23 23:45                       ` Mike Frysinger
2011-06-23 23:48                         ` Brian Norris
2011-06-24 20:20                 ` Artem Bityutskiy
2011-06-26  7:15                   ` Peter Korsgaard
2011-06-24 17:37               ` Brian Norris
2011-06-24 18:28                 ` Mike Frysinger
2011-06-24 19:21                   ` Artem Bityutskiy
2011-06-24 20:11                 ` Artem Bityutskiy
2011-06-24 20:15               ` Artem Bityutskiy
2011-06-24 19:38             ` Artem Bityutskiy
2011-06-22 16:49     ` [PATCH v3 1/7] nanddump: add --bb=METHOD option Brian Norris
2011-06-22 16:49     ` Brian Norris [this message]
2011-06-22 16:49     ` [PATCH v3 3/7] nanddump: update help message for BB method changes Brian Norris
2011-06-22 16:49     ` [PATCH v3 4/7] nanddump: warn about new default BB handling Brian Norris
2011-06-22 16:49     ` [PATCH v3 5/7] feature-removal-schedule: describe nanddump changes Brian Norris
2011-06-22 16:49     ` [PATCH v3 6/7] nanddump: add --oob option Brian Norris
2011-06-22 16:49     ` [PATCH v3 7/7] nanddump: document, warn about future default --omitoob Brian Norris

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1308761363-16512-3-git-send-email-computersforpeace@gmail.com \
    --to=computersforpeace@gmail.com \
    --cc=dedekind1@gmail.com \
    --cc=dwmw2@infradead.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=vapier.adi@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.