From: Artem Bityutskiy <dedekind1@gmail.com>
To: David Wagner <david.wagner@free-electrons.com>
Cc: linux-mtd@lists.infradead.org
Subject: Re: [PATCHv2] UBI: clarify the volume notification types' doc
Date: Thu, 23 Jun 2011 17:51:36 +0300 [thread overview]
Message-ID: <1308840701.23597.8.camel@sauron> (raw)
In-Reply-To: <4DFF687B.6070806@free-electrons.com>
On Mon, 2011-06-20 at 17:34 +0200, David Wagner wrote:
> I realized the new descriptions of ADDED and REMOVED could also be
> misleading: they can also be triggered after using a userland util
> (ubi{mk,rm}vol).
>
> (the indentation looks odd but is fine once the patch has been applied)
>
> Signed-off-by David Wagner <david.wagner@free-electrons.com>
> ---
> include/linux/mtd/ubi.h | 12 +++++++-----
> 1 files changed, 7 insertions(+), 5 deletions(-)
>
> diff --git a/include/linux/mtd/ubi.h b/include/linux/mtd/ubi.h
> index b31bd9e..b79e741 100644
> --- a/include/linux/mtd/ubi.h
> +++ b/include/linux/mtd/ubi.h
> @@ -134,11 +134,13 @@ struct ubi_device_info {
>
> /*
> * enum - volume notification types.
> - * @UBI_VOLUME_ADDED: volume has been added
> - * @UBI_VOLUME_REMOVED: start volume volume
> - * @UBI_VOLUME_RESIZED: volume size has been re-sized
> - * @UBI_VOLUME_RENAMED: volume name has been re-named
> - * @UBI_VOLUME_UPDATED: volume name has been updated
> + * @UBI_VOLUME_ADDED: a volume has been added (containing device attached
> + * or volume created from a userland util)
> + * @UBI_VOLUME_REMOVED: a volume has been removed (containing device
> detached
The patch is corrupted because of line-wrapping, but I fixed it and
amended the comments a bit (did not like the "userland util" phrase),
and pushed to ubi-2.6.git tree, thanks.
--
Best Regards,
Artem Bityutskiy
prev parent reply other threads:[~2011-06-23 14:51 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-20 9:27 [PATCH] UBI: clarify the volume notification types' doc David Wagner
2011-06-20 15:34 ` [PATCHv2] " David Wagner
2011-06-23 14:51 ` Artem Bityutskiy [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1308840701.23597.8.camel@sauron \
--to=dedekind1@gmail.com \
--cc=david.wagner@free-electrons.com \
--cc=linux-mtd@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.