From: Ben Hutchings <bhutchings@solarflare.com>
To: greearb@candelatech.com
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH 1/2] net: Support RXFCS feature flag.
Date: Fri, 24 Jun 2011 00:22:08 +0100 [thread overview]
Message-ID: <1308871328.3093.1020.camel@localhost> (raw)
In-Reply-To: <1308870819-15938-2-git-send-email-greearb@candelatech.com>
On Thu, 2011-06-23 at 16:13 -0700, greearb@candelatech.com wrote:
> From: Ben Greear <greearb@candelatech.com>
>
> When set, this causes the Ethernet FCS to be appended
> to the end of the skb.
>
> Useful for sniffing packets.
[...]
> --- a/include/linux/ethtool.h
> +++ b/include/linux/ethtool.h
> @@ -347,6 +347,7 @@ struct ethtool_perm_addr {
> * flag differs from the read-only value.
> */
> enum ethtool_flags {
> + ETH_FLAG_RXFCS = (1 << 0), /* Append FCS to skb */
> ETH_FLAG_TXVLAN = (1 << 7), /* TX VLAN offload enabled */
> ETH_FLAG_RXVLAN = (1 << 8), /* RX VLAN offload enabled */
> ETH_FLAG_LRO = (1 << 15), /* LRO is enabled */
[...]
No, all new features should be accessed through the
ETHTOOL_{G,S}FEATURES commands only.
Ben.
--
Ben Hutchings, Senior Software Engineer, Solarflare
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.
next prev parent reply other threads:[~2011-06-23 23:22 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-23 23:13 [PATCH 0/2] Enable RXFCS as a feature greearb
2011-06-23 23:13 ` [PATCH 1/2] net: Support RXFCS feature flag greearb
2011-06-23 23:22 ` Ben Hutchings [this message]
2011-06-23 23:13 ` [PATCH 2/2] e100: " greearb
-- strict thread matches above, loose matches on Subject: below --
2012-02-06 18:39 [PATCH 1/2] net: " greearb
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1308871328.3093.1020.camel@localhost \
--to=bhutchings@solarflare.com \
--cc=greearb@candelatech.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.