From: "Brian Norris" <computersforpeace@gmail.com>
To: "Artem Bityutskiy" <dedekind1@gmail.com>
Cc: David Woodhouse <dwmw2@infradead.org>,
Brian Norris <computersforpeace@gmail.com>,
linux-mtd@lists.infradead.org,
Mike Frysinger <vapier.adi@gmail.com>
Subject: [PATCH 3/6] nanddump: change -o to mean --oob, not --omitoob
Date: Fri, 24 Jun 2011 11:03:11 -0700 [thread overview]
Message-ID: <1308938594-20486-4-git-send-email-computersforpeace@gmail.com> (raw)
In-Reply-To: <1308938594-20486-1-git-send-email-computersforpeace@gmail.com>
As warned earlier, we are changing the meaning of `nanddump -o' to
mirror the usage in nandwrite, where -o means to include OOB (i.e.,
`nandwrite -o' writes data to both in-band and out-of-band areas, so
`nanddump -o' should dump data from both in-band and out-of-band areas).
Signed-off-by: Brian Norris <computersforpeace@gmail.com>
---
nanddump.c | 14 +++++++-------
1 files changed, 7 insertions(+), 7 deletions(-)
diff --git a/nanddump.c b/nanddump.c
index 9edfbfd..adf268b 100644
--- a/nanddump.c
+++ b/nanddump.c
@@ -53,8 +53,8 @@ static void display_help(void)
"-f file --file=file Dump to file\n"
"-l length --length=length Length\n"
"-n --noecc Read without error correction\n"
-"-o --omitoob Omit OOB data (default in next release)\n"
-" --oob Dump OOB data (current default)\n"
+" --omitoob Omit OOB data (default in next release)\n"
+"-o --oob Dump OOB data (current default)\n"
"-p --prettyprint Print nice (hexdump)\n"
"-q --quiet Don't display progress and status messages\n"
"-s addr --startaddress=addr Start address\n"
@@ -119,12 +119,12 @@ static void process_options(int argc, char * const argv[])
{"help", no_argument, 0, 0},
{"version", no_argument, 0, 0},
{"bb", required_argument, 0, 0},
- {"oob", no_argument, 0, 0},
+ {"omitoob", no_argument, 0, 0},
{"forcebinary", no_argument, 0, 'a'},
{"canonicalprint", no_argument, 0, 'c'},
{"file", required_argument, 0, 'f'},
+ {"oob", no_argument, 0, 'o'},
{"prettyprint", no_argument, 0, 'p'},
- {"omitoob", no_argument, 0, 'o'},
{"startaddress", required_argument, 0, 's'},
{"length", required_argument, 0, 'l'},
{"noecc", no_argument, 0, 'n'},
@@ -159,10 +159,10 @@ static void process_options(int argc, char * const argv[])
error++;
bb_default = false;
break;
- case 3: /* --oob */
+ case 3: /* --omitoob */
if (oob_default) {
oob_default = false;
- omitoob = false;
+ omitoob = true;
} else {
errmsg_die("--oob and --oomitoob are mutually exclusive");
}
@@ -184,7 +184,7 @@ static void process_options(int argc, char * const argv[])
case 'o':
if (oob_default) {
oob_default = false;
- omitoob = true;
+ omitoob = false;
} else {
errmsg_die("--oob and --oomitoob are mutually exclusive");
}
--
1.7.0.4
next prev parent reply other threads:[~2011-06-24 18:05 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-24 18:03 [PATCH 0/6] complete nanddump feature-removals Brian Norris
2011-06-24 18:03 ` [PATCH 1/6] nanddump: kill --omitbad, --noskipbad Brian Norris
2011-06-24 18:08 ` Brian Norris
2011-06-24 18:03 ` [PATCH 2/6] nanddump: change default to --bb=skipbad Brian Norris
2011-06-24 18:03 ` Brian Norris [this message]
2011-06-24 18:03 ` [PATCH 4/6] nanddump: default to NOT dumping OOB data Brian Norris
2011-06-24 18:03 ` [PATCH 5/6] feature-removal: remove completed tasks Brian Norris
2011-06-24 18:03 ` [PATCH 6/6] integck: fix build error (MS_DIRSYNC, MS_RELATIME) Brian Norris
2011-06-25 7:03 ` [PATCH 0/6] complete nanddump feature-removals Artem Bityutskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1308938594-20486-4-git-send-email-computersforpeace@gmail.com \
--to=computersforpeace@gmail.com \
--cc=dedekind1@gmail.com \
--cc=dwmw2@infradead.org \
--cc=linux-mtd@lists.infradead.org \
--cc=vapier.adi@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.