From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ben Skeggs Date: Sat, 25 Jun 2011 11:59:07 +0000 Subject: Re: [patch] nouveau: free the memory in nouveau_gart_manager_del() Message-Id: <1309003308.3557.4.camel@nisroch> List-Id: References: <20110625055324.GS14591@shale.localdomain> In-Reply-To: <20110625055324.GS14591@shale.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Dan Carpenter Cc: kernel-janitors@vger.kernel.org, Roy Spliet , "open list:DRM DRIVERS" On Sat, 2011-06-25 at 08:53 +0300, Dan Carpenter wrote: > In the original code the kfree() doesn't do anything because > "mem->mm_node" has been set to NULL. This was introduced in > d2f96666c56a "drm/nouveau: create temp vmas for both src and dst of > bo moves" Already fixed in nouveau git, I'll get the fixes to Dave. Ben. > > Signed-off-by: Dan Carpenter > > diff --git a/drivers/gpu/drm/nouveau/nouveau_mem.c b/drivers/gpu/drm/nouveau/nouveau_mem.c > index 765f0e5..ab79bf8 100644 > --- a/drivers/gpu/drm/nouveau/nouveau_mem.c > +++ b/drivers/gpu/drm/nouveau/nouveau_mem.c > @@ -846,8 +846,8 @@ nouveau_gart_manager_del(struct ttm_mem_type_manager *man, > struct ttm_mem_reg *mem) > { > nouveau_mem_node_cleanup(mem->mm_node); > - mem->mm_node = NULL; > kfree(mem->mm_node); > + mem->mm_node = NULL; > } > > static int From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ben Skeggs Subject: Re: [patch] nouveau: free the memory in nouveau_gart_manager_del() Date: Sat, 25 Jun 2011 22:01:43 +1000 Message-ID: <1309003308.3557.4.camel@nisroch> References: <20110625055324.GS14591@shale.localdomain> Reply-To: bskeggs@redhat.com Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by gabe.freedesktop.org (Postfix) with ESMTP id 3ABC59E74F for ; Sat, 25 Jun 2011 04:59:01 -0700 (PDT) In-Reply-To: <20110625055324.GS14591@shale.localdomain> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org Errors-To: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org To: Dan Carpenter Cc: kernel-janitors@vger.kernel.org, Roy Spliet , "open list:DRM DRIVERS" List-Id: dri-devel@lists.freedesktop.org On Sat, 2011-06-25 at 08:53 +0300, Dan Carpenter wrote: > In the original code the kfree() doesn't do anything because > "mem->mm_node" has been set to NULL. This was introduced in > d2f96666c56a "drm/nouveau: create temp vmas for both src and dst of > bo moves" Already fixed in nouveau git, I'll get the fixes to Dave. Ben. > > Signed-off-by: Dan Carpenter > > diff --git a/drivers/gpu/drm/nouveau/nouveau_mem.c b/drivers/gpu/drm/nouveau/nouveau_mem.c > index 765f0e5..ab79bf8 100644 > --- a/drivers/gpu/drm/nouveau/nouveau_mem.c > +++ b/drivers/gpu/drm/nouveau/nouveau_mem.c > @@ -846,8 +846,8 @@ nouveau_gart_manager_del(struct ttm_mem_type_manager *man, > struct ttm_mem_reg *mem) > { > nouveau_mem_node_cleanup(mem->mm_node); > - mem->mm_node = NULL; > kfree(mem->mm_node); > + mem->mm_node = NULL; > } > > static int