From: Mike Galbraith <mgalbraith@suse.de>
To: Ingo Molnar <mingo@elte.hu>
Cc: LKML <linux-kernel@vger.kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
Peter Zijlstra <a.p.zijlstra@chello.nl>
Subject: Re: [rfc patch] x86,apic: fix DEBUG_PREEMPT gripe when booting with threadirqs=1
Date: Sun, 26 Jun 2011 14:33:14 +0200 [thread overview]
Message-ID: <1309091594.11217.18.camel@marge.simson.net> (raw)
In-Reply-To: <20110626104521.GE11093@elte.hu>
On Sun, 2011-06-26 at 12:45 +0200, Ingo Molnar wrote:
> * Mike Galbraith <mgalbraith@suse.de> wrote:
>
> > x86,apic: fix DEBUG_PREEMPT gripe when booting with threadirqs=1
> >
> > If CONFIG_PREEMPT and CONFIG_INTR_REMAP are both set, and a box is
> > booted with threadirqs, the gripe below is emitted. It was suggested
> > that native_smp_prepare_cpus() shouldn't need to be run with preemption
> > disabled, and indeed, box boots with no hint of trouble. Remove it.
>
> Would also require a careful review of the code we take out of
> preempt protection now - have you done that by any chance? (if not,
> mind doing it?)
No, I haven't, I have only empirical evidence of having yet to see any
nastiness with an RT kernel.
I'll crawl through it once I get a couple PCI configuration space
thingies sorted. I'm rather expecting to then find out why
INTR_REMAP/DMAR + X2APIC is disabled.. the head-on collision way.
-Mike
prev parent reply other threads:[~2011-06-26 12:34 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-22 11:57 [rfc patch] x86,apic: fix DEBUG_PREEMPT gripe when booting with threadirqs=1 Mike Galbraith
2011-06-26 10:45 ` Ingo Molnar
2011-06-26 12:33 ` Mike Galbraith [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1309091594.11217.18.camel@marge.simson.net \
--to=mgalbraith@suse.de \
--cc=a.p.zijlstra@chello.nl \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.