From: jamal <hadi@cyberus.ca>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: David Miller <davem@davemloft.net>,
Herbert Xu <herbert@gondor.apana.org.au>,
netdev@vger.kernel.org
Subject: Re: [PATCH] net_sched: fix dequeuer fairness
Date: Sun, 26 Jun 2011 11:32:14 -0400 [thread overview]
Message-ID: <1309102334.5134.31.camel@mojatatu> (raw)
In-Reply-To: <1309100994.2532.35.camel@edumazet-laptop>
On Sun, 2011-06-26 at 17:09 +0200, Eric Dumazet wrote:
> I would just remove the jiffies break, now we have a 64 packets limit...
>
> if (quota >= work || need_resched()) {
> ...
> }
Seems reasonable to do. Some stats (on two different machines
at least with dummy) on a system with low # of processes:
~80% of the time - we exit the loop because of packet quota
~1% for both need_resched and jiffy
~19% simply because there were less than quota packets
Note: we do use a jiffy check on net_rx_action() but i suspect
we never ever hit it.
cheers,
jamal
next prev parent reply other threads:[~2011-06-26 15:32 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-26 14:07 [PATCH] net_sched: fix dequeuer fairness jamal
2011-06-26 14:17 ` jamal
2011-06-26 14:53 ` Ben Hutchings
2011-06-26 15:27 ` jamal
2011-06-26 15:09 ` Eric Dumazet
2011-06-26 15:32 ` jamal [this message]
2011-06-26 15:53 ` Eric Dumazet
2011-06-26 16:13 ` jamal
2011-06-26 16:03 ` jamal
2011-06-26 16:26 ` Eric Dumazet
2011-06-26 16:29 ` jamal
2011-06-26 21:18 ` Ben Hutchings
2011-06-26 16:38 ` jamal
2011-06-26 18:13 ` jamal
2011-06-27 7:15 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1309102334.5134.31.camel@mojatatu \
--to=hadi@cyberus.ca \
--cc=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=herbert@gondor.apana.org.au \
--cc=jhs@mojatatu.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.