From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from he.sipsolutions.net ([78.46.109.217]:37992 "EHLO sipsolutions.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757123Ab1F0Ikw (ORCPT ); Mon, 27 Jun 2011 04:40:52 -0400 Subject: Re: [PATCH 18/25] iwlagn: warn about nested SYNC commands From: Johannes Berg To: Wey-Yi Guy Cc: linville@tuxdriver.com, linux-wireless@vger.kernel.org, Emmanuel Grumbach In-Reply-To: <1308411271-26093-19-git-send-email-wey-yi.w.guy@intel.com> (sfid-20110618_180558_166798_E27083E7) References: <1308411271-26093-1-git-send-email-wey-yi.w.guy@intel.com> <1308411271-26093-19-git-send-email-wey-yi.w.guy@intel.com> (sfid-20110618_180558_166798_E27083E7) Content-Type: text/plain; charset="UTF-8" Date: Mon, 27 Jun 2011 10:40:53 +0200 Message-ID: <1309164053.3911.3.camel@jlt3.sipsolutions.net> (sfid-20110627_104220_919345_63C0C0BA) Mime-Version: 1.0 Sender: linux-wireless-owner@vger.kernel.org List-ID: On Sat, 2011-06-18 at 08:34 -0700, Wey-Yi Guy wrote: > From: Emmanuel Grumbach > > Since there is no protection around SYNC host command mechanism, at least WARN > when collision happens between two SYNC host comamnds. I am not sure there is a > real issue (beyond the HCMD_ACTIVE flag maintenance) with having two SYNC host > commands at the same time, but at least now, we will know about it. Please drop this particular patch. We discussed this but then forgot about it -- this patch only warns when collisions actually happen, but we can use lockdep to warn when collisions _could_ happen as well. johannes