From: Chris Wilson <chris@chris-wilson.co.uk>
To: Konstantin Belousov <kostikbel@gmail.com>,
Intel-gfx <Intel-gfx@lists.freedesktop.org>
Subject: Re: Recent changes
Date: Tue, 28 Jun 2011 11:37:00 +0100 [thread overview]
Message-ID: <1309257422_33463@CP5-2952> (raw)
In-Reply-To: <20110628093604.GG48734@deviant.kiev.zoral.com.ua>
On Tue, 28 Jun 2011 12:36:04 +0300, Konstantin Belousov <kostikbel@gmail.com> wrote:
> I have two questions about recent changes made to the kernel driver:
>
> 1. Looking at the intel_setup_overlay() after the commit
> ecbec53b1d00ba582f71b210ed96cafc05ebd189, it seems there is potential
> double unlock for the struct_mutex in the (unlikely) case when
> intel_overlay_map_regs() failed.
Dan Carpenter pointed out a further mistake in that we weren't handling
the pin count correctly for 945/965/g33.
> 2. In i915_wait_request(), after the commit
> 4697995b98417c6da9ab2708a36f5e2bc926c8ac, shouldn't the calls
> i915_driver_irq_preinstall(ring->dev);
> i915_driver_irq_postinstall(ring->dev);
> be replaced with
> ring->dev->driver->irq_preinstall(ring->dev);
> ring->dev->driver->irq_postinstall(ring->dev);
> ?
Yes.
-Chris
--
Chris Wilson, Intel Open Source Technology Centre
next prev parent reply other threads:[~2011-06-28 10:37 UTC|newest]
Thread overview: 135+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-28 9:36 Recent changes Konstantin Belousov
2011-06-28 10:37 ` Chris Wilson [this message]
[not found] <20120406040004.1BF99484001@kernel.dk>
2012-04-06 4:29 ` Danny Kukawka
2012-04-06 13:31 ` Jens Axboe
2012-04-06 17:40 ` Danny Kukawka
2012-04-06 17:44 ` Jens Axboe
2012-04-14 6:45 ` Danny Kukawka
2012-04-14 14:47 ` Jens Axboe
-- strict thread matches above, loose matches on Subject: below --
2011-10-14 4:00 Jens Axboe
[not found] <20110125050003.F378B37A302@kernel.dk>
2011-01-27 21:08 ` Steven Pratt
2011-01-27 21:12 ` Jens Axboe
2011-01-27 22:06 ` Bruce Cran
2011-01-28 8:28 ` Jens Axboe
[not found] <20110127050004.1AE9737A304@kernel.dk>
2011-01-27 8:51 ` Bruce Cran
2011-01-27 9:08 ` Jens Axboe
[not found] <20110114050004.0ECBF37A2F4@kernel.dk>
2011-01-14 11:38 ` Bruce Cran
2011-01-14 11:41 ` Jens Axboe
2010-11-06 5:00 Jens Axboe
[not found] <869776.96350.qm@web63807.mail.re1.yahoo.com>
2009-04-24 4:40 ` Gurudas Pai
[not found] <20090409040002.0D18237A271@kernel.dk>
2009-04-17 21:38 ` Girish Satihal
2009-04-18 17:48 ` Jens Axboe
2009-04-20 14:42 ` Girish Satihal
2009-04-20 18:05 ` Jens Axboe
2009-04-20 20:54 ` Girish Satihal
2009-04-21 5:28 ` Jens Axboe
2009-04-21 7:47 ` Jens Axboe
2009-04-21 15:46 ` Girish Satihal
2009-04-21 19:15 ` Jens Axboe
2009-04-21 22:17 ` Girish Satihal
2009-04-22 5:46 ` Jens Axboe
2009-04-22 5:53 ` Gurudas Pai
2009-04-22 16:46 ` Girish Satihal
2009-04-22 17:40 ` Jens Axboe
2007-04-07 3:56 Jens Axboe
2007-04-14 4:00 ` Jens Axboe
2007-04-15 4:00 ` Jens Axboe
2007-04-17 4:00 ` Jens Axboe
2007-04-19 4:00 ` Jens Axboe
2007-05-12 4:00 ` Jens Axboe
2007-05-17 4:00 ` Jens Axboe
2007-05-22 4:00 ` Jens Axboe
2007-05-31 4:00 ` Jens Axboe
2007-06-01 4:00 ` Jens Axboe
2007-06-14 4:00 ` Jens Axboe
2007-07-19 4:00 ` Jens Axboe
2007-07-25 4:00 ` Jens Axboe
2007-07-31 4:00 ` Jens Axboe
2007-08-21 4:00 ` Jens Axboe
2007-08-27 4:00 ` Jens Axboe
2007-08-28 4:00 ` Jens Axboe
2007-08-29 4:00 ` Jens Axboe
2007-09-11 4:00 ` Jens Axboe
2007-10-02 4:00 ` Jens Axboe
2007-10-03 4:00 ` Jens Axboe
2007-10-06 4:00 ` Jens Axboe
2007-10-11 4:00 ` Jens Axboe
2007-10-30 5:00 ` Jens Axboe
2007-11-09 5:00 ` Jens Axboe
2007-11-14 5:00 ` Jens Axboe
2007-11-15 5:00 ` Jens Axboe
2007-12-07 5:00 ` Jens Axboe
2007-12-08 5:00 ` Jens Axboe
2007-12-10 5:00 ` Jens Axboe
2007-12-11 5:00 ` Jens Axboe
2008-01-04 5:00 ` Jens Axboe
2008-02-01 5:00 ` Jens Axboe
2008-02-06 5:00 ` Jens Axboe
2008-02-09 5:00 ` Jens Axboe
2008-02-13 5:00 ` Jens Axboe
2008-02-14 5:00 ` Jens Axboe
2008-02-23 5:00 ` Jens Axboe
2008-04-03 4:00 ` Jens Axboe
2008-04-03 7:04 ` Jens Axboe
2008-05-06 4:00 ` Jens Axboe
2008-05-09 4:00 ` Jens Axboe
2008-05-10 4:00 ` Jens Axboe
2008-05-13 4:00 ` Jens Axboe
2008-05-19 4:00 ` Jens Axboe
2008-05-22 4:00 ` Jens Axboe
2008-05-28 4:00 ` Jens Axboe
2008-07-02 4:00 ` Jens Axboe
2008-08-16 4:00 ` Jens Axboe
2008-09-27 4:00 ` Jens Axboe
2008-10-11 4:00 ` Jens Axboe
2008-10-17 4:00 ` Jens Axboe
2008-10-18 4:00 ` Jens Axboe
2008-10-21 4:00 ` Jens Axboe
2008-10-29 5:00 ` Jens Axboe
2008-10-31 5:00 ` Jens Axboe
2008-11-11 5:00 ` Jens Axboe
2008-11-12 5:00 ` Jens Axboe
2008-11-13 5:00 ` Jens Axboe
2009-01-13 5:00 ` Jens Axboe
2009-01-22 5:00 ` Jens Axboe
2009-01-24 5:00 ` Jens Axboe
2009-02-10 5:00 ` Jens Axboe
2009-02-12 5:00 ` Jens Axboe
2009-02-13 5:00 ` Jens Axboe
2009-02-14 5:00 ` Jens Axboe
2009-02-18 5:00 ` Jens Axboe
2009-02-19 5:00 ` Jens Axboe
2009-03-13 5:00 ` Jens Axboe
2009-03-24 5:00 ` Jens Axboe
2009-03-26 5:00 ` Jens Axboe
2009-03-27 5:00 ` Jens Axboe
2009-04-07 4:00 ` Jens Axboe
2009-04-18 4:00 ` Jens Axboe
2009-04-22 4:00 ` Jens Axboe
2009-05-13 4:00 ` Jens Axboe
2009-08-15 4:00 ` Jens Axboe
2009-09-02 4:00 ` Jens Axboe
2009-10-09 4:00 ` Jens Axboe
2009-10-10 4:00 ` Jens Axboe
2010-02-23 5:00 ` Jens Axboe
2010-03-23 5:00 ` Jens Axboe
2010-04-20 4:00 ` Jens Axboe
2010-04-21 4:00 ` Jens Axboe
2010-09-17 4:00 ` Jens Axboe
2010-10-12 15:38 ` Edward Shishkin
2010-10-12 16:52 ` Jens Axboe
2010-10-23 4:00 ` Jens Axboe
2010-12-02 5:00 ` Jens Axboe
2010-12-20 4:36 ` Duy Le (Dan)
2011-01-12 5:00 ` Jens Axboe
2011-01-15 5:00 ` Jens Axboe
2011-02-10 5:00 ` Jens Axboe
2011-03-17 5:00 ` Jens Axboe
2011-05-27 4:00 ` Jens Axboe
2011-08-04 4:00 ` Jens Axboe
2011-08-04 11:50 ` Edward Shishkin
2011-08-04 12:08 ` Jens Axboe
2011-08-12 4:00 ` Jens Axboe
2012-02-01 5:00 ` Jens Axboe
2012-02-02 5:00 ` Jens Axboe
2012-02-28 5:00 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1309257422_33463@CP5-2952 \
--to=chris@chris-wilson.co.uk \
--cc=Intel-gfx@lists.freedesktop.org \
--cc=kostikbel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.