Re: [LTP] [PATCH] getsid01.c: Convert to new LTP API

[Avinesh Kumar <akumar@suse.de>]

Hi Li,

On Wednesday, August 31, 2022 12:05:32 PM IST Li Wang wrote:
> Hi Avinesh,
> 
> Avinesh Kumar <akumar@suse.de> wrote:
> 
> 
> > -       for (lc = 0; TEST_LOOPING(lc); lc++) {
> > -               /* reset tst_count in case we are looping */
> > -               tst_count = 0;
> > +       TEST(getsid(0));
> > +       p_sid = TST_RET;
> >
> 
> We'd better examine TST_RET not equal -1, otherwise, the test can
> still report pass with two wrong values (-1) returned. isn't it?
> 
> 
> > +               c_sid = TST_RET;
> >
> 
> Here as well.
Yes, thank you for pointing this out, sending v2.

> 
> 
> 

Regards,
Avinesh




-- 
Mailing list info: https://lists.linux.it/listinfo/ltp