From: "Brian Norris" <computersforpeace@gmail.com>
To: "Artem Bityutskiy" <dedekind1@gmail.com>
Cc: Jim Quinlan <jim2101024@gmail.com>,
David Woodhouse <dwmw2@infradead.org>,
Brian Norris <computersforpeace@gmail.com>,
linux-mtd@lists.infradead.org,
Kevin Cernekee <cernekee@gmail.com>
Subject: [PATCH 2/3] mtd: tests: ignore corrected bitflips in OOB on mtd_readtest
Date: Tue, 28 Jun 2011 16:28:59 -0700 [thread overview]
Message-ID: <1309303740-9936-3-git-send-email-computersforpeace@gmail.com> (raw)
In-Reply-To: <1309303740-9936-1-git-send-email-computersforpeace@gmail.com>
read_oob may now return ECC error codes. If the code is -EUCLEAN, then
we can safely ignore the error as a corrected bitflip.
Signed-off-by: Brian Norris <computersforpeace@gmail.com>
---
drivers/mtd/tests/mtd_readtest.c | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/drivers/mtd/tests/mtd_readtest.c b/drivers/mtd/tests/mtd_readtest.c
index afe71aa..de23e8e 100644
--- a/drivers/mtd/tests/mtd_readtest.c
+++ b/drivers/mtd/tests/mtd_readtest.c
@@ -75,7 +75,8 @@ static int read_eraseblock_by_page(int ebnum)
ops.datbuf = NULL;
ops.oobbuf = oobbuf;
ret = mtd->read_oob(mtd, addr, &ops);
- if (ret || ops.oobretlen != mtd->oobsize) {
+ if (ret && ret != -EUCLEAN ||
+ ops.oobretlen != mtd->oobsize) {
printk(PRINT_PREF "error: read oob failed at "
"%#llx\n", (long long)addr);
if (!err)
--
1.7.0.4
next prev parent reply other threads:[~2011-06-28 23:30 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-28 23:28 [PATCH 0/3] fixups for OOB ECC problems Brian Norris
2011-06-28 23:28 ` [PATCH 1/3] mtd: nand: ignore ECC errors for simple BBM scans Brian Norris
2011-06-29 7:02 ` Artem Bityutskiy
2011-06-28 23:28 ` Brian Norris [this message]
2011-06-28 23:29 ` [PATCH 3/3] mtd: edit NAND-related comment Brian Norris
2011-06-29 6:59 ` [PATCH 0/3] fixups for OOB ECC problems Artem Bityutskiy
2011-06-29 20:24 ` Brian Norris
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1309303740-9936-3-git-send-email-computersforpeace@gmail.com \
--to=computersforpeace@gmail.com \
--cc=cernekee@gmail.com \
--cc=dedekind1@gmail.com \
--cc=dwmw2@infradead.org \
--cc=jim2101024@gmail.com \
--cc=linux-mtd@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.