From: Zhang Rui <rui.zhang@intel.com>
To: "H.J. Lu" <hjl.tools@gmail.com>
Cc: "acpi@linux.intel.com" <acpi@linux.intel.com>,
"linux-acpi@vger.kernel.org" <linux-acpi@vger.kernel.org>
Subject: Re: PATCH: Don't enable GPE if GPE dispatch failed
Date: Wed, 29 Jun 2011 09:35:10 +0800 [thread overview]
Message-ID: <1309311310.5389.2.camel@rui> (raw)
In-Reply-To: <1309311174.5389.0.camel@rui>
CC linux-acpi mail list.
On Wed, 2011-06-29 at 09:32 +0800, Zhang, Rui wrote:
> Hi,
>
> can you send me the acpidump output of this machine please?
>
> thanks,
> rui
>
> On Wed, 2011-06-29 at 06:05 +0800, Lu, Hongjiu wrote:
> > Hi,
> >
> > I have a broken BIOS, which generates thousands of kernel messages:
> >
> > Jun 28 14:13:26 gnu-18 kernel: [ 628.704003] ACPI Exception: AE_NOT_EXIST, while evaluating GPE method [_L01] (20110112/evgpe-551)
> > Jun 28 14:13:26 gnu-18 kernel: [ 628.826752] ACPI Error: No handler for Region [ECF2] (ffff88013763b6c0) [EmbeddedControl] (20110112/evregion-369)
> > Jun 28 14:13:26 gnu-18 kernel: [ 628.826761] ACPI Error: Region EmbeddedControl(0x3) has no handler (20110112/exfldio-292)
> > Jun 28 14:13:26 gnu-18 kernel: [ 628.826768] ACPI Error: Method parse/execution failed [\_GPE._L01] (Node ffff88013765a488), AE_NOT_EXIST (20110112/psparse-536)
> >
> > This patch avoids enabling GPE if GPE dispatch failed. Now I got only
> > one kernel message:
> >
> > Jun 28 14:38:51 gnu-18 kernel: [ 0.937479] ACPI Error: No handler for Region [ECF2] (ffff88013763b6c0) [EmbeddedControl] (20110112/evregion-369)
> > Jun 28 14:38:51 gnu-18 kernel: [ 0.937485] ACPI Error: Region EmbeddedControl(0x3) has no handler (20110112/exfldio-292)
> > Jun 28 14:38:51 gnu-18 kernel: [ 0.937490] ACPI Error: Method parse/execution failed [\_GPE._L01] (Node ffff88013765a488), AE_NOT_EXIST (20110112/psparse-536)
> > Jun 28 14:38:51 gnu-18 kernel: [ 0.937502] ACPI Exception: AE_NOT_EXIST, while evaluating GPE method [_L01] (20110112/evgpe-551)
> >
> >
> >
> > H.J.
> > ---
> > diff --git a/drivers/acpi/acpica/evgpe.c b/drivers/acpi/acpica/evgpe.c
> > index f472521..5b1f4b2 100644
> > --- a/drivers/acpi/acpica/evgpe.c
> > +++ b/drivers/acpi/acpica/evgpe.c
> > @@ -559,11 +559,13 @@ static void ACPI_SYSTEM_XFACE acpi_ev_asynch_execute_gpe_method(void *context)
> >
> > /* Defer enabling of GPE until all notify handlers are done */
> >
> > - status = acpi_os_execute(OSL_NOTIFY_HANDLER,
> > - acpi_ev_asynch_enable_gpe,
> > - local_gpe_event_info);
> > - if (ACPI_FAILURE(status)) {
> > - ACPI_FREE(local_gpe_event_info);
> > + if (!ACPI_FAILURE(status)) {
> > + status = acpi_os_execute(OSL_NOTIFY_HANDLER,
> > + acpi_ev_asynch_enable_gpe,
> > + local_gpe_event_info);
> > + if (ACPI_FAILURE(status)) {
> > + ACPI_FREE(local_gpe_event_info);
> > + }
> > }
> > return_VOID;
> > }
> >
> > _______________________________________________
> > acpi mailing list
> > acpi@linux.intel.com
> > http://linux.intel.com/mailman/listinfo/acpi
>
>
> _______________________________________________
> acpi mailing list
> acpi@linux.intel.com
> http://linux.intel.com/mailman/listinfo/acpi
next parent reply other threads:[~2011-06-29 1:32 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20110628220535.GA19846@intel.com>
[not found] ` <1309311174.5389.0.camel@rui>
2011-06-29 1:35 ` Zhang Rui [this message]
[not found] ` <BANLkTinqc5FeP9x3B=QjQ0RaXJPytYzn4A@mail.gmail.com>
2011-06-29 6:19 ` PATCH: Don't enable GPE if GPE dispatch failed Zhang Rui
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1309311310.5389.2.camel@rui \
--to=rui.zhang@intel.com \
--cc=acpi@linux.intel.com \
--cc=hjl.tools@gmail.com \
--cc=linux-acpi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.