All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tatyana Brokhman <tlinder-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
To: balbi-l0cyMroinI0@public.gmane.org
Cc: greg-U8xfFu+wG4EAvxtiuMwx3w@public.gmane.org,
	linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-arm-msm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	ablay-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org,
	Tatyana Brokhman
	<tlinder-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
Subject: Adding SS support to the Gadget FW - fix
Date: Wed, 29 Jun 2011 15:34:54 +0300	[thread overview]
Message-ID: <1309350899-23868-1-git-send-email-tlinder@codeaurora.org> (raw)

Hi Felipe

Due to Greg comments on "[PATCH 06/41] usb: gadget: add max_speed to 
usb_composite_driver" I modified this patch and removed the 
#ifdef CONFIG_USB_GADGET_DUALSPEED from different gadget drivers, as
he requested.
In "usb: gadget: add SuperSpeed support to the Gadget Framework" patch 
I removed one small unnecessary comment (that he commented about) and
since I already touched this patch - merged the patch you had on 
your branch that fixed ARM compilation.

I also changed min()->min_t() in composite.c where the casting was done
for both parameters. Unfortunately, due to personal reasons I woun't be
able to continue with fixing all gadget drivers to use min_t() instead
of min() in the near future. So I at least fixed the one place that
pushed me into this change in the first place :)

I wasn't sure what is the best (and most convenient for you) branch to
base this on so this is what I did:
- the patches are based on Greg's tree (usb-next branch)
- I took the patches from your for-next branch since you updated the
commit messages and I wanted to preserve that.

Since these 2 patches are independent of the patches adding SS support to 
dummy_hcd, and the fact that Sebastian modified the code, I didn't touch
the dummy_hcd patches and thus no point in resending those. 

Hope this is ok with you. Let me know if you prefer this to be done in
some other way.

Tatyana Brokhman (2):
  usb: gadget: add max_speed to usb_composite_driver
  usb: gadget: add SuperSpeed support to the Gadget Framework

 drivers/usb/gadget/Kconfig        |    6 +
 drivers/usb/gadget/audio.c        |    1 +
 drivers/usb/gadget/cdc2.c         |    1 +
 drivers/usb/gadget/composite.c    |  259 ++++++++++++++++++++++++++++++++++---
 drivers/usb/gadget/epautoconf.c   |    6 +-
 drivers/usb/gadget/ether.c        |    1 +
 drivers/usb/gadget/g_ffs.c        |    1 +
 drivers/usb/gadget/hid.c          |    1 +
 drivers/usb/gadget/mass_storage.c |    1 +
 drivers/usb/gadget/multi.c        |    1 +
 drivers/usb/gadget/ncm.c          |    1 +
 drivers/usb/gadget/nokia.c        |    1 +
 drivers/usb/gadget/serial.c       |    1 +
 drivers/usb/gadget/webcam.c       |    1 +
 drivers/usb/gadget/zero.c         |    1 +
 include/linux/usb/composite.h     |   16 +++
 include/linux/usb/gadget.h        |   31 +++++
 17 files changed, 309 insertions(+), 21 deletions(-)

-- 
1.7.3.3

--
Sent by an employee of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

             reply	other threads:[~2011-06-29 12:34 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-06-29 12:34 Tatyana Brokhman [this message]
2011-06-29 12:34 ` [PATCH v2 1/2] usb: gadget: add max_speed to usb_composite_driver Tatyana Brokhman
2011-06-29 12:34   ` Tatyana Brokhman
2011-06-29 12:38   ` Felipe Balbi
2011-06-29 12:45     ` Tanya Brokhman
2011-06-29 12:45       ` Tanya Brokhman
2011-06-29 12:48       ` Felipe Balbi
2011-06-29 17:27         ` Tanya Brokhman
2011-06-29 17:27           ` Tanya Brokhman
2011-06-29 19:41           ` Felipe Balbi
2011-06-30  5:14             ` Tanya Brokhman
2011-06-30  5:14               ` Tanya Brokhman
2011-06-30  5:21               ` Greg KH
     [not found]                 ` <20110630052156.GA24087-U8xfFu+wG4EAvxtiuMwx3w@public.gmane.org>
2011-06-30  5:41                   ` Tanya Brokhman
2011-06-30  5:41                     ` Tanya Brokhman
2011-06-30  5:46                     ` Tanya Brokhman
2011-06-30  5:46                       ` Tanya Brokhman
2011-06-29 12:34 ` [PATCH v2 2/2] usb: gadget: add SuperSpeed support to the Gadget Framework Tatyana Brokhman
2011-06-29 12:34   ` Tatyana Brokhman
2011-06-29 12:42   ` Felipe Balbi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1309350899-23868-1-git-send-email-tlinder@codeaurora.org \
    --to=tlinder-sgv2jx0feol9jmxxk+q4oq@public.gmane.org \
    --cc=ablay-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org \
    --cc=balbi-l0cyMroinI0@public.gmane.org \
    --cc=greg-U8xfFu+wG4EAvxtiuMwx3w@public.gmane.org \
    --cc=linux-arm-msm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.