From: Alex Elder <aelder@sgi.com>
To: sekharan@us.ibm.com
Cc: Christoph Hellwig <hch@infradead.org>,
XFS Mailing List <xfs@oss.sgi.com>
Subject: Re: [PATCH] xfs: replace bp->flags usage with predefined macros
Date: Wed, 29 Jun 2011 16:58:26 -0500 [thread overview]
Message-ID: <1309384706.8649.31.camel@doink> (raw)
In-Reply-To: <1309379623.5505.6222.camel@chandra-lucid.beaverton.ibm.com>
On Wed, 2011-06-29 at 13:33 -0700, Chandra Seetharaman wrote:
> On Wed, 2011-06-29 at 02:30 -0400, Christoph Hellwig wrote:
> > On Wed, Jun 29, 2011 at 02:46:16PM +1000, Dave Chinner wrote:
> > > On Tue, Jun 28, 2011 at 05:53:04PM -0700, Chandra Seetharaman wrote:
> > > > Cleanup: Replace bp->flags usage with predefined macros.
> > > >
> > > > Signed-off-by: Chandra Seetharaman <sekharan@us.ibm.com>
> > >
> > > Christoph can correct me if I'm wrong, but I'm pretty sure his long term
> > > direction is to remove the XFS_BUF_* macros completely.
> >
> > Yes, at least those that are simpler flags get/set/clear wrappers.
>
> So, the suggestion is to go the other way and remove all the wrappers
> and use bp->flags directly ?
Yes, that's right.
Sorry about that. Chandra asked me for some things to do
on XFS so I fired a few small simple odds and ends I had
made note of along the way. This was one--I said that the
use of macros should be consistent. I said we should
eventually do away with them entirely, but I didn't recommend
he do that right now since this was being done by a new
contributor.
Chandra, I think if you're up to it, doing away with the
macros is the right way to go.
-Alex
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2011-06-29 21:58 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-29 0:53 [PATCH] xfs: replace bp->flags usage with predefined macros Chandra Seetharaman
2011-06-29 4:46 ` Dave Chinner
2011-06-29 6:30 ` Christoph Hellwig
2011-06-29 20:33 ` Chandra Seetharaman
2011-06-29 21:58 ` Alex Elder [this message]
2011-06-29 22:02 ` Chandra Seetharaman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1309384706.8649.31.camel@doink \
--to=aelder@sgi.com \
--cc=hch@infradead.org \
--cc=sekharan@us.ibm.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.