From: Fam Zheng <famcool@gmail.com>
To: qemu-devel@nongnu.org
Cc: kwolf@redhat.com, Fam Zheng <famcool@gmail.com>,
hch@lst.de, stefanha@gmail.com
Subject: [Qemu-devel] [PATCH v6 03/12] VMDK: probe for monolithicFlat images
Date: Fri, 1 Jul 2011 12:55:33 +0800 [thread overview]
Message-ID: <1309496142-14228-4-git-send-email-famcool@gmail.com> (raw)
In-Reply-To: <1309496142-14228-1-git-send-email-famcool@gmail.com>
Probe as the same behavior as VMware does.
Recognize image as monolithicFlat descriptor file when the file is text
and the first effective line (not '#' leaded comment or space line) is
either 'version=1' or 'version=2'. No space or upper case charactors
accepted.
Signed-off-by: Fam Zheng <famcool@gmail.com>
---
block/vmdk.c | 44 ++++++++++++++++++++++++++++++++++++++++++--
1 files changed, 42 insertions(+), 2 deletions(-)
diff --git a/block/vmdk.c b/block/vmdk.c
index 557e01e..4684670 100644
--- a/block/vmdk.c
+++ b/block/vmdk.c
@@ -102,10 +102,50 @@ static int vmdk_probe(const uint8_t *buf, int buf_size, const char *filename)
return 0;
magic = be32_to_cpu(*(uint32_t *)buf);
if (magic == VMDK3_MAGIC ||
- magic == VMDK4_MAGIC)
+ magic == VMDK4_MAGIC) {
return 100;
- else
+ } else {
+ const char *p = (const char *)buf;
+ const char *end = p + buf_size;
+ while (p < end) {
+ if (*p == '#') {
+ /* skip comment line */
+ while (p < end && *p != '\n') {
+ p++;
+ }
+ p++;
+ continue;
+ }
+ if (*p == ' ') {
+ while (p < end && *p == ' ') {
+ p++;
+ }
+ /* skip '\r' if windows line endings used. */
+ if (p < end && *p == '\r') {
+ p++;
+ }
+ /* only accept blank lines before 'version=' line */
+ if (p == end || *p != '\n') {
+ return 0;
+ }
+ p++;
+ continue;
+ }
+ if (end - p >= strlen("version=X\n")) {
+ if (strncmp("version=1\n", p, strlen("version=1\n")) == 0 ||
+ strncmp("version=2\n", p, strlen("version=2\n")) == 0) {
+ return 100;
+ }
+ }
+ if (end - p >= strlen("version=X\r\n")) {
+ if (strncmp("version=1\r\n", p, strlen("version=1\r\n")) == 0 ||
+ strncmp("version=2\r\n", p, strlen("version=2\r\n")) == 0) {
+ return 100;
+ }
+ }
+ }
return 0;
+ }
}
#define CHECK_CID 1
next prev parent reply other threads:[~2011-07-01 4:56 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-01 4:55 [Qemu-devel] [PATCH v6 00/12] Adding VMDK monolithic flat support Fam Zheng
2011-07-01 4:55 ` [Qemu-devel] [PATCH v6 01/12] VMDK: introduce VmdkExtent Fam Zheng
2011-07-01 12:28 ` Kevin Wolf
2011-07-01 4:55 ` [Qemu-devel] [PATCH v6 02/12] VMDK: bugfix, align offset to cluster in get_whole_cluster Fam Zheng
2011-07-01 4:55 ` Fam Zheng [this message]
2011-07-01 4:55 ` [Qemu-devel] [PATCH v6 04/12] VMDK: separate vmdk_open by format version Fam Zheng
2011-07-01 13:02 ` Kevin Wolf
2011-07-01 13:06 ` Fam Zheng
2011-07-01 13:13 ` Kevin Wolf
2011-07-01 4:55 ` [Qemu-devel] [PATCH v6 05/12] VMDK: add field BDRVVmdkState.desc_offset Fam Zheng
2011-07-01 13:08 ` Kevin Wolf
2011-07-01 4:55 ` [Qemu-devel] [PATCH v6 06/12] VMDK: flush multiple extents Fam Zheng
2011-07-01 4:55 ` [Qemu-devel] [PATCH v6 07/12] VMDK: move 'static' cid_update flag to bs field Fam Zheng
2011-07-01 4:55 ` [Qemu-devel] [PATCH v6 08/12] VMDK: change get_cluster_offset return type Fam Zheng
2011-07-01 16:40 ` Kevin Wolf
2011-07-01 4:55 ` [Qemu-devel] [PATCH v6 09/12] VMDK: open/read/write for monolithicFlat image Fam Zheng
2011-07-01 5:23 ` Stefan Hajnoczi
2011-07-01 4:55 ` [Qemu-devel] [PATCH v6 10/12] VMDK: create different subformats Fam Zheng
2011-07-01 4:55 ` [Qemu-devel] [PATCH v6 11/12] VMDK: fix coding style Fam Zheng
2011-07-01 4:55 ` [Qemu-devel] [PATCH v6 12/12] block: add bdrv_get_allocated_file_size() operation Fam Zheng
2011-07-01 5:25 ` [Qemu-devel] [PATCH v6 00/12] Adding VMDK monolithic flat support Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1309496142-14228-4-git-send-email-famcool@gmail.com \
--to=famcool@gmail.com \
--cc=hch@lst.de \
--cc=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.