From: Phil Blundell <philb@gnu.org>
To: openembedded-devel@lists.openembedded.org
Subject: Re: [meta-oe][PATCH] systemd_git.bb: Alias mkostemp() to mkstemp() for uclibc targets
Date: Fri, 01 Jul 2011 10:48:43 +0100 [thread overview]
Message-ID: <1309513723.2633.32.camel@phil-desktop> (raw)
In-Reply-To: <1309498698-13369-1-git-send-email-raj.khem@gmail.com>
On Thu, 2011-06-30 at 22:38 -0700, Khem Raj wrote:
> ++#ifdef __UCLIBC__
> ++/* uclibc does not implement mkostemp GNU extention */
> ++#define mkostemp(x,y) mkstemp(x)
> ++#endif
Is that safe? It would be nice to have some commentary in the patch
explaining why the flags are not required for systemd to operate
correctly. If it genuinely doesn't need to be using mkostemp() then
perhaps this change should just be made upstream for all libcs.
p.
next prev parent reply other threads:[~2011-07-01 9:52 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-01 5:38 [meta-oe][PATCH] systemd_git.bb: Alias mkostemp() to mkstemp() for uclibc targets Khem Raj
2011-07-01 7:01 ` Koen Kooi
2011-07-01 8:47 ` Paul Menzel
2011-07-01 17:19 ` Khem Raj
2011-07-01 9:48 ` Phil Blundell [this message]
2011-07-01 13:48 ` Khem Raj
2011-07-01 14:23 ` Phil Blundell
2011-07-01 17:11 ` Khem Raj
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1309513723.2633.32.camel@phil-desktop \
--to=philb@gnu.org \
--cc=openembedded-devel@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.