From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: Patches and discussions about the oe-core layer
<openembedded-core@lists.openembedded.org>
Subject: Re: It's broken, please revert. Re: [PATCH 0/4 V4] Share gcc work directories
Date: Fri, 01 Jul 2011 12:28:21 +0100 [thread overview]
Message-ID: <1309519701.20015.519.camel@rex> (raw)
In-Reply-To: <D2DB54E8-BE7A-4036-9F5A-587D90844875@dominion.thruhere.net>
On Fri, 2011-07-01 at 11:08 +0200, Koen Kooi wrote:
> Op 1 jul 2011, om 10:10 heeft Richard Purdie het volgende geschreven:
>
> > On Fri, 2011-07-01 at 09:15 +0200, Koen Kooi wrote:
> >> Op 1 jul 2011, om 01:26 heeft Saul Wold het volgende geschreven:
> > Testing patches is not the sole responsibility of myself and Saul. This
> > gcc patchset was on the mailing list for a considerable time and has
> > been tested in a variety of ways. Various breakage was identified found
> > and those breakages were fixed. The fact there looks to be some
> > incremental build issue with rm_work is unfortunate and likely easy to
> > fix so I think this request is a little out of proportion.
> >
> > If someone had reported the problem before it merged it would have
> > waited until it was fixed before merging.
>
> "They will therefore merge and I'm happy with them but it will be a few
> more days before that happens. "
>
> I was under the impression that I still had a few more days to test
> them now that the eglibc problems have been solved. I don't think you
> can blame people for not testing gcc when eglibc was still blowing up
> in their faces.
I balanced a few different factors in the timing. Merging code like this
on a Friday with 4th July and the US going on holiday next week didn't
seem like a better time to do this so I went for something slightly
earlier. I was working on the assumption we had the eglibc issues
resolved.
> > I find it ironic you're one of the people asking to turn the autobuilder
> > red, make warnings fatal and break things for everyone as 'its the only
> > way to get people to look at and fix them; but on the other hand you're
> > unhappy if testing of patches doesn't happen on every single combination
> > of usages and something does break :/.
>
> I was actually planning to test them today, now that eglibc works again.
Ok, sorry I wasn't aware of that.
Cheers,
Richard
next prev parent reply other threads:[~2011-07-01 11:32 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-28 9:05 [PATCH 0/4 V4] Share gcc work directories Robert Yang
2011-06-28 9:05 ` [PATCH 1/4 V4] bitbake: share source directory Robert Yang
2011-06-28 11:19 ` Richard Purdie
2011-06-28 9:05 ` [PATCH 2/4 V4] Share gcc work directories Robert Yang
2011-06-28 9:05 ` [PATCH 3/4 V4] gcc-4.5.1: share " Robert Yang
2011-06-28 9:05 ` [PATCH 4/4 V4] gcc-4.6: " Robert Yang
2011-06-28 14:53 ` [PATCH 0/4 V4] Share gcc " Richard Purdie
2011-06-30 23:26 ` Saul Wold
2011-07-01 7:15 ` It's broken, please revert. " Koen Kooi
2011-07-01 8:10 ` Richard Purdie
2011-07-01 9:08 ` Koen Kooi
2011-07-01 11:28 ` Richard Purdie [this message]
2011-07-01 8:32 ` Richard Purdie
2011-07-01 11:00 ` Koen Kooi
2011-07-01 13:57 ` Khem Raj
2011-07-01 14:01 ` Koen Kooi
2011-07-01 16:55 ` Khem Raj
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1309519701.20015.519.camel@rex \
--to=richard.purdie@linuxfoundation.org \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.