From: Ian Campbell <Ian.Campbell@citrix.com>
To: Olaf Hering <olaf@aepfle.de>
Cc: "xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>
Subject: Re: [PATCH] tools/libxl: testenum.c depends on libxl.h
Date: Mon, 4 Jul 2011 14:27:25 +0100 [thread overview]
Message-ID: <1309786045.634.76.camel@zakaz.uk.xensource.com> (raw)
In-Reply-To: <20110704131823.GA8215@aepfle.de>
On Mon, 2011-07-04 at 14:18 +0100, Olaf Hering wrote:
> testenum.c may fail to compile if libxl.h dependencies are not yet met.
Ah yes, because the automated .*.d dependency tracking hasn't kicked in
on a fresh build yet.
[...]
> Signed-off-by: Olaf Hering <olaf@aepfle.de>
Acked-by: Ian Campbell <ian.campbell@citrix.com>
>
> Index: xen-unstable.hg-4.2.23655/tools/libxl/Makefile
> ===================================================================
> --- xen-unstable.hg-4.2.23655.orig/tools/libxl/Makefile
> +++ xen-unstable.hg-4.2.23655/tools/libxl/Makefile
> @@ -52,7 +52,7 @@ $(XL_OBJS): CFLAGS += $(CFLAGS_libxenctr
> $(XL_OBJS): CFLAGS += $(CFLAGS_libxenlight)
>
> testenum.o: CFLAGS += $(CFLAGS_libxenctrl) $(CFLAGS_libxenlight)
> -testenum.c: libxl.idl gentest.py
> +testenum.c: libxl.idl gentest.py libxl.h
> $(PYTHON) gentest.py libxl.idl testenum.c.new
> mv testenum.c.new testenum.c
>
>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xensource.com
> http://lists.xensource.com/xen-devel
next prev parent reply other threads:[~2011-07-04 13:27 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-04 13:18 [PATCH] tools/libxl: testenum.c depends on libxl.h Olaf Hering
2011-07-04 13:27 ` Ian Campbell [this message]
2011-07-06 15:32 ` Ian Jackson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1309786045.634.76.camel@zakaz.uk.xensource.com \
--to=ian.campbell@citrix.com \
--cc=olaf@aepfle.de \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.