diff for duplicates of <130be7db-6098-86a4-60fe-0c1a5d9e30ba@kernel.org> diff --git a/a/1.txt b/N1/1.txt index 3fa55f7..4cea722 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -1,35 +1,41 @@ +From: Paul Walmsley <pjw@kernel.org> -It's customary for NOKPROBE_SYMBOL() macro usage to appear immedately -after a function's final closing brace, but checkpatch doesn't know -that yet. As a result, checkpatch --strict incorrectly flags this -common kernel pattern, e.g., - -CHECK: Please use a blank line after function/struct/union/enum declarations -33: FILE: arch/riscv/kernel/traps.c:273: - } -+NOKPROBE_SYMBOL(probe_single_step_handler); - -Fix by adding NOKPROBE_SYMBOL to the whitelist of patterns that are -cleared to appear immediately after functions. - -Cc: Nam Cao <namcao@linutronix.de> -Cc: Jisheng Zhang <jszhang@kernel.org> -Signed-off-by: Paul Walmsley <pjw@kernel.org> ---- - scripts/checkpatch.pl | 1 + - 1 file changed, 1 insertion(+) - -diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl -index 2b7a42bbdd94..f8a57ed71f34 100755 ---- a/scripts/checkpatch.pl -+++ b/scripts/checkpatch.pl -@@ -4148,6 +4148,7 @@ sub process { - $line =~ /^\+[a-z_]*init/ || - $line =~ /^\+\s*(?:static\s+)?[A-Z_]*ATTR/ || - $line =~ /^\+\s*DECLARE/ || -+ $line =~ /^\+\s*NOKPROBE_SYMBOL/ || - $line =~ /^\+\s*builtin_[\w_]*driver/ || - $line =~ /^\+\s*__setup/)) { - if (CHK("LINE_SPACING", --- -2.53.0 +> It's customary for NOKPROBE_SYMBOL() macro usage to appear immedately +> after a function's final closing brace, but checkpatch doesn't know +> that yet. As a result, checkpatch --strict incorrectly flags this +> common kernel pattern, e.g., + +> CHECK: Please use a blank line after function/struct/union/enum declarations +> 33: FILE: arch/riscv/kernel/traps.c:273: +> } +> +NOKPROBE_SYMBOL(probe_single_step_handler); + +> Fix by adding NOKPROBE_SYMBOL to the whitelist of patterns that are +> cleared to appear immediately after functions. + +> Cc: Nam Cao <namcao@linutronix.de> +> Cc: Jisheng Zhang <jszhang@kernel.org> +> Signed-off-by: Paul Walmsley <pjw@kernel.org> +> --- +> scripts/checkpatch.pl | 1 + +> 1 file changed, 1 insertion(+) + +> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl +> index 2b7a42bbdd94..f8a57ed71f34 100755 +> --- a/scripts/checkpatch.pl +> +++ b/scripts/checkpatch.pl +> @@ -4148,6 +4148,7 @@ sub process { +> $line =~ /^\+[a-z_]*init/ || +> $line =~ /^\+\s*(?:static\s+)?[A-Z_]*ATTR/ || +> $line =~ /^\+\s*DECLARE/ || +> + $line =~ /^\+\s*NOKPROBE_SYMBOL/ || +> $line =~ /^\+\s*builtin_[\w_]*driver/ || +> $line =~ /^\+\s*__setup/)) { +> if (CHK("LINE_SPACING", + ++1 + +Reviewed-by: Petr Vorel <pvorel@suse.cz> + +Kind regards, +Petr diff --git a/a/content_digest b/N1/content_digest index ebe9c78..20008f2 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -1,47 +1,56 @@ - "From\0Paul Walmsley <pjw@kernel.org>\0" + "From\0Petr Vorel <pvorel@suse.cz>\0" "Subject\0[PATCH] checkpatch: add NOKPROBE_SYMBOL to the whitelist of lines that can occur immediately after functions\0" - "Date\0Thu, 6 Aug 2026 19:00:47 -0600 (MDT)\0" - "To\0apw@canonical.com" + "Date\0Mon, 10 Aug 2026 18:57:28 +0200\0" + "To\0pjw@kernel.org" + apw@canonical.com joe@perches.com " linux-kernel@vger.kernel.org\0" - "Cc\0Nam Cao <namcao@linutronix.de>" - " Jisheng Zhang <jszhang@kernel.org>\0" + "Cc\0jszhang@kernel.org" + namcao@linutronix.de + Andrew Morton <akpm@linux-foundation.org> + " Petr Vorel <pvorel@suse.cz>\0" "\00:1\0" "b\0" + "From: Paul Walmsley <pjw@kernel.org>\n" "\n" - "It's customary for NOKPROBE_SYMBOL() macro usage to appear immedately\n" - "after a function's final closing brace, but checkpatch doesn't know\n" - "that yet. As a result, checkpatch --strict incorrectly flags this\n" - "common kernel pattern, e.g.,\n" - "\n" - "CHECK: Please use a blank line after function/struct/union/enum declarations\n" - "33: FILE: arch/riscv/kernel/traps.c:273:\n" - " }\n" - "+NOKPROBE_SYMBOL(probe_single_step_handler);\n" - "\n" - "Fix by adding NOKPROBE_SYMBOL to the whitelist of patterns that are\n" - "cleared to appear immediately after functions.\n" - "\n" - "Cc: Nam Cao <namcao@linutronix.de>\n" - "Cc: Jisheng Zhang <jszhang@kernel.org>\n" - "Signed-off-by: Paul Walmsley <pjw@kernel.org>\n" - "---\n" - " scripts/checkpatch.pl | 1 +\n" - " 1 file changed, 1 insertion(+)\n" - "\n" - "diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl\n" - "index 2b7a42bbdd94..f8a57ed71f34 100755\n" - "--- a/scripts/checkpatch.pl\n" - "+++ b/scripts/checkpatch.pl\n" - "@@ -4148,6 +4148,7 @@ sub process {\n" - " \t\t $line =~ /^\\+[a-z_]*init/ ||\n" - " \t\t $line =~ /^\\+\\s*(?:static\\s+)?[A-Z_]*ATTR/ ||\n" - " \t\t $line =~ /^\\+\\s*DECLARE/ ||\n" - "+\t\t $line =~ /^\\+\\s*NOKPROBE_SYMBOL/ ||\n" - " \t\t $line =~ /^\\+\\s*builtin_[\\w_]*driver/ ||\n" - " \t\t $line =~ /^\\+\\s*__setup/)) {\n" - " \t\t\tif (CHK(\"LINE_SPACING\",\n" - "-- \n" - 2.53.0 + "> It's customary for NOKPROBE_SYMBOL() macro usage to appear immedately\n" + "> after a function's final closing brace, but checkpatch doesn't know\n" + "> that yet. As a result, checkpatch --strict incorrectly flags this\n" + "> common kernel pattern, e.g.,\n" + "\n" + "> CHECK: Please use a blank line after function/struct/union/enum declarations\n" + "> 33: FILE: arch/riscv/kernel/traps.c:273:\n" + "> }\n" + "> +NOKPROBE_SYMBOL(probe_single_step_handler);\n" + "\n" + "> Fix by adding NOKPROBE_SYMBOL to the whitelist of patterns that are\n" + "> cleared to appear immediately after functions.\n" + "\n" + "> Cc: Nam Cao <namcao@linutronix.de>\n" + "> Cc: Jisheng Zhang <jszhang@kernel.org>\n" + "> Signed-off-by: Paul Walmsley <pjw@kernel.org>\n" + "> ---\n" + "> scripts/checkpatch.pl | 1 +\n" + "> 1 file changed, 1 insertion(+)\n" + "\n" + "> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl\n" + "> index 2b7a42bbdd94..f8a57ed71f34 100755\n" + "> --- a/scripts/checkpatch.pl\n" + "> +++ b/scripts/checkpatch.pl\n" + "> @@ -4148,6 +4148,7 @@ sub process {\n" + "> \t\t $line =~ /^\\+[a-z_]*init/ ||\n" + "> \t\t $line =~ /^\\+\\s*(?:static\\s+)?[A-Z_]*ATTR/ ||\n" + "> \t\t $line =~ /^\\+\\s*DECLARE/ ||\n" + "> +\t\t $line =~ /^\\+\\s*NOKPROBE_SYMBOL/ ||\n" + "> \t\t $line =~ /^\\+\\s*builtin_[\\w_]*driver/ ||\n" + "> \t\t $line =~ /^\\+\\s*__setup/)) {\n" + "> \t\t\tif (CHK(\"LINE_SPACING\",\n" + "\n" + "+1\n" + "\n" + "Reviewed-by: Petr Vorel <pvorel@suse.cz>\n" + "\n" + "Kind regards,\n" + Petr -17b9e6b54efa9388519eab7d50937aa9a0818dd7302cbe67cac00fd38a12f24a +f3f270fd55943c53209fd021e721abf2ea7070c2cc6b9ccb7341efd36b8d0a4c
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.