From: Artem Bityutskiy <dedekind1@gmail.com>
To: Anatolij Gustschin <agust@denx.de>
Cc: linux-mtd@lists.infradead.org, Detlev Zundel <dzu@denx.de>
Subject: Re: [PATCH v2] UBIFS: fix master node recovery
Date: Thu, 07 Jul 2011 12:55:48 +0300 [thread overview]
Message-ID: <1310032552.3149.145.camel@sauron> (raw)
In-Reply-To: <1310032278-5102-1-git-send-email-agust@denx.de>
On Thu, 2011-07-07 at 11:51 +0200, Anatolij Gustschin wrote:
> diff --git a/fs/ubifs/recovery.c b/fs/ubifs/recovery.c
> index 783d8e0..9d7e387 100644
> --- a/fs/ubifs/recovery.c
> +++ b/fs/ubifs/recovery.c
> @@ -274,7 +274,8 @@ int ubifs_recover_master_node(struct ubifs_info *c)
> if (cor1)
> goto out_err;
> mst = mst1;
> - } else if (offs1 == 0 && offs2 + sz >= c->leb_size) {
> + } else if (offs1 == 0 &&
> + (c->leb_size - offs2 - sz) < sz) {
Sorry for netpick, but I think you do not have to embrace the expression
into the brackets, and then may be it fits into one line? Anyway, I can
amend it myself, you do not have to send another patch, but you can if
you want.
--
Best Regards,
Artem Bityutskiy
next prev parent reply other threads:[~2011-07-07 9:54 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-06 9:30 [PATCH] UBIFS: fix master node recovery Anatolij Gustschin
2011-07-07 6:15 ` Artem Bityutskiy
2011-07-07 7:36 ` Anatolij Gustschin
2011-07-07 6:26 ` Artem Bityutskiy
2011-07-07 7:43 ` Anatolij Gustschin
2011-07-07 7:57 ` Artem Bityutskiy
2011-07-07 8:44 ` Anatolij Gustschin
2011-07-07 8:57 ` Artem Bityutskiy
2011-07-07 9:05 ` Anatolij Gustschin
2011-07-07 9:51 ` [PATCH v2] " Anatolij Gustschin
2011-07-07 9:55 ` Artem Bityutskiy [this message]
2011-07-07 10:25 ` [PATCH v3] " Anatolij Gustschin
2011-07-08 3:55 ` Artem Bityutskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1310032552.3149.145.camel@sauron \
--to=dedekind1@gmail.com \
--cc=agust@denx.de \
--cc=dzu@denx.de \
--cc=linux-mtd@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.