All of lore.kernel.org
 help / color / mirror / Atom feed
From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: Yu Ke <ke.yu@intel.com>
Cc: openembedded-core@lists.openembedded.org
Subject: Re: [PATCH 4/8] python: fix for libdir=/usr/lib64 case
Date: Thu, 07 Jul 2011 20:22:25 +0100	[thread overview]
Message-ID: <1310066545.20015.844.camel@rex> (raw)
In-Reply-To: <46e97fb7d91eecd7e874e65a59b88a1e51ca131f.1310047266.git.ke.yu@intel.com>

On Thu, 2011-07-07 at 22:10 +0800, Yu Ke wrote:
> python has several place hard code "lib" which breaks build
> when libdir=/usr/lib64. SUSE has a patch to fix this issue.
> 
> So this patch add the SUSE patch to address this issue
> 
> Signed-off-by: Yu Ke <ke.yu@intel.com>
[...]
> ++AC_SUBST(LIB)
> ++AC_MSG_CHECKING(LIB)
> ++case $ac_sys_system in
> ++Linux*)
> ++  # Test if the compiler is 64bit
> ++  echo 'int i;' > conftest.$ac_ext
> ++  python_cv_cc_64bit_output=no
> ++  if AC_TRY_EVAL(ac_compile); then
> ++    case `/usr/bin/file conftest.$ac_objext` in
> ++    *"ELF 64"*)
> ++      python_cv_cc_64bit_output=yes
> ++      ;;
> ++    esac
> ++  fi
> ++  rm -rf conftest*
> ++  ;;
> ++esac
> ++
> ++case $ARCH:$python_cv_cc_64bit_output in
> ++ppc64:yes | powerpc64:yes | s390x:yes | sparc64:yes | x86_64:yes)
> ++  LIB="lib64"
> ++  ;;
> ++*:*)
> ++  LIB="lib"
> ++  ;;
> ++esac
> ++AC_MSG_RESULT($LIB)
> + 

This patch is good apart from this bit. I think we need to be able to
pass in our own string to use here which we derive from the libdir
variable...

Cheers,

Richard




  reply	other threads:[~2011-07-07 23:33 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-07-07 14:10 [PATCH 0/8] [RFC] patch for non /usr/lib libdir Yu Ke
2011-07-07 14:10 ` [PATCH 1/8] native.bbclass: generate libdir from libdir_native Yu Ke
2011-07-07 14:10 ` [PATCH 2/8] openssl: fix for non /usr/lib libdir case Yu Ke
2011-07-07 14:10 ` [PATCH 3/8] libc-package.bbclass: " Yu Ke
2011-07-08 17:15   ` Richard Purdie
2011-07-07 14:10 ` [PATCH 4/8] python: fix for libdir=/usr/lib64 case Yu Ke
2011-07-07 19:22   ` Richard Purdie [this message]
2011-07-08  0:52     ` Yu Ke
2011-07-07 14:10 ` [PATCH 5/8] python-native: fix for non /usr/lib libdir case Yu Ke
2011-07-07 14:10 ` [PATCH 6/8] perl: " Yu Ke
2011-07-07 16:14   ` Kamble, Nitin A
2011-07-07 19:21     ` Richard Purdie
2011-07-07 14:10 ` [PATCH 7/8] libcap: " Yu Ke
2011-07-07 14:10 ` [PATCH 8/8] rpm: " Yu Ke

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1310066545.20015.844.camel@rex \
    --to=richard.purdie@linuxfoundation.org \
    --cc=ke.yu@intel.com \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.