From: Jose Alonso <joalonsof@gmail.com>
To: Matthew Garrett <mjg59@srcf.ucam.org>
Cc: linux-kernel@vger.kernel.org
Subject: [PATCH] dell-laptop - using buffer without mutex_lock
Date: Fri, 08 Jul 2011 19:01:27 -0300 [thread overview]
Message-ID: <1310162490.9760.5.camel@laptop> (raw)
Using buffer->output[1] without mutex_lock()
--- linux-3.0-rc6/drivers/platform/x86/dell-laptop.c.ORIG
2011-07-04 19:56:24.000000000 -0300
+++ linux-3.0-rc6/drivers/platform/x86/dell-laptop.c 2011-07-08
18:27:02.420791868 -0300
@@ -560,11 +560,11 @@
else
dell_send_request(buffer, 0, 1);
+ ret = buffer->output[1];
+
out:
release_buffer();
- if (ret)
- return ret;
- return buffer->output[1];
+ return ret;
}
static const struct backlight_ops dell_ops = {
next reply other threads:[~2011-07-08 22:01 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-08 22:01 Jose Alonso [this message]
2011-07-09 21:28 ` [PATCH] dell-laptop - using buffer without mutex_lock Greg Dietsche
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1310162490.9760.5.camel@laptop \
--to=joalonsof@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mjg59@srcf.ucam.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.