All of lore.kernel.org
 help / color / mirror / Atom feed
From: bjschuma@netapp.com
To: bfields@fieldses.org
Cc: linux-nfs@vger.kernel.org, Bryan Schumaker <bjschuma@netapp.com>
Subject: [PATCH v4 0/2]  NFSD: add FREE_STATEID and TEST_STATEID operations
Date: Tue, 12 Jul 2011 08:42:52 -0400	[thread overview]
Message-ID: <1310474574-4518-1-git-send-email-bjschuma@netapp.com> (raw)

From: Bryan Schumaker <bjschuma@netapp.com>

These patches add FREE_STATEID and TEST_STATEID to the NFS server.  I initially
tested them by hard coding calls both before and after the client completes a
CLOSE operation.  Eventually, I modified the client's state recovery code to
place these calls.  I would turn off networking on the client for two minutes
so it would expired on the server and force recovery once networking was
reenabled.

I later added in a fault injection framework on the server.  I would have the
client acquire a lock, tell the server to delete it, and then have the client
use TEST_STATEID and FREE_STATEID to recover the lock.

v2:
- FREE_STATEID
  - Free open, lock, and delegation state ids correctly
  - Use the check_for_locks() function to check for locks

  - TEST_STATEID
    - Remove openmode check
    - Sanity check on size of stateid list
    - Delay decoding stateid list until encoding the reply

v3:
  - FREE_STATEID
    - Open stateids and delegations are never freeable (return nfserr_locks_held)

  - TEST_STATEID
    - Remove unused arguments from a function call
    - Store and use the HAS_SESSION flag for validating stateids

v4:
  - FREE_STATEID
    - Remove unused argument from nfs4_free_lock_stateid()

  - TEST_STATEID
    - Remove double call to nfs4_validate_stateid()

- Bryan

             reply	other threads:[~2011-07-12 12:42 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-07-12 12:42 bjschuma [this message]
2011-07-12 12:42 ` [PATCH v4 1/2] NFSD: added FREE_STATEID operation bjschuma
2011-07-12 12:42 ` [PATCH v4 2/2] NFSD: Added TEST_STATEID operation bjschuma
2011-07-13  0:42   ` J. Bruce Fields
2011-07-13 13:03     ` Bryan Schumaker
  -- strict thread matches above, loose matches on Subject: below --
2011-07-08 20:28 [PATCH v4 0/2] NFSD: add FREE_STATEID and TEST_STATEID operations bjschuma

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1310474574-4518-1-git-send-email-bjschuma@netapp.com \
    --to=bjschuma@netapp.com \
    --cc=bfields@fieldses.org \
    --cc=linux-nfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.