From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: Joshua Lock <josh@linux.intel.com>
Cc: bitbake-devel@lists.openembedded.org
Subject: Re: [PATCH 3/3] cooker: only return *Found events if something was actually found
Date: Wed, 13 Jul 2011 12:27:17 +0100 [thread overview]
Message-ID: <1310556437.20015.1108.camel@rex> (raw)
In-Reply-To: <7cb0ce38f4b80a2cace870bd0ab5af4f003b433c.1310507186.git.josh@linux.intel.com>
On Tue, 2011-07-12 at 14:49 -0700, Joshua Lock wrote:
> @@ -569,7 +570,8 @@ class BBCooker:
> if p.search(f):
> matches.append(f)
>
> - bb.event.fire(bb.event.FilesMatchingFound(filepattern, matches), self.configuration.data)
> + if len(matches):
> + bb.event.fire(bb.event.FilesMatchingFound(filepattern, matches), self.configuration.data)
I think this can just be "if matches:"
> def findConfigFiles(self, varname):
> """
> @@ -592,7 +594,8 @@ class BBCooker:
> if end == 'conf':
> possible.append(val)
>
> - bb.event.fire(bb.event.ConfigFilesFound(var, possible), self.configuration.data)
> + if len(possible):
> + bb.event.fire(bb.event.ConfigFilesFound(var, possible), self.configuration.data)
>
> def findInheritsClass(self, klass):
> """
ditto.
Cheers,
Richard
next prev parent reply other threads:[~2011-07-13 11:31 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-12 21:48 [PATCH 0/3] Bug fixes for the hob GUI Joshua Lock
2011-07-12 21:48 ` [PATCH 1/3] ui/crumbs/tasklistmodel: update brought in by column when possible Joshua Lock
2011-07-12 21:48 ` [PATCH 2/3] ui/crumbs/tasklistmodel: fix automatic removal of orphaned items Joshua Lock
2011-07-12 21:49 ` [PATCH 3/3] cooker: only return *Found events if something was actually found Joshua Lock
2011-07-13 11:27 ` Richard Purdie [this message]
2011-07-13 11:28 ` [PATCH 0/3] Bug fixes for the hob GUI Richard Purdie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1310556437.20015.1108.camel@rex \
--to=richard.purdie@linuxfoundation.org \
--cc=bitbake-devel@lists.openembedded.org \
--cc=josh@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.