All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alex Elder <aelder@sgi.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: xfs@oss.sgi.com, alal@google.com
Subject: Re: [PATCH 1/1] Fix the ltp Makefile to allow for installation of all non-c (scripts) files
Date: Wed, 13 Jul 2011 13:26:04 -0500	[thread overview]
Message-ID: <1310581564.1998.38.camel@doink> (raw)
In-Reply-To: <20110713121320.GA28126@infradead.org>

On Wed, 2011-07-13 at 08:13 -0400, Christoph Hellwig wrote:
> On Fri, Jul 01, 2011 at 01:52:43PM -0700, Akshay Lal wrote:
> > Current the Makefile only builds the .c files and installs
> > them in the $INSTALL path. However, the ltp directory contains a shell script,
> > which doen't get copied over (installed) when a "make install"is invoked.
> > 
> > This behaviour causes test 080 to fail since it requires rwtest.sh to be
> > present in the ltp/ directory.
> > 
> > Tested: Updated the Makefile and ran a static build script & test
> > 080.
> 
> Thanks, applied.  (after fixing up mailer induced whitespace issues)

I see that test 80 is not part of the "auto" group.  Anyone
know why not?  I'm not even sure what it does; it may just
be unnecessary because it duplicates what other tests do.

But it's really quick (under 10 seconds even without speedy
hardware) so I don't see any harm to adding it to "auto" as
well as "quick".

Any thoughts?

					-Alex

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

  reply	other threads:[~2011-07-13 18:26 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-07-01 20:52 [PATCH 1/1] Fix the ltp Makefile to allow for installation of all non-c (scripts) files Akshay Lal
2011-07-13 12:13 ` Christoph Hellwig
2011-07-13 18:26   ` Alex Elder [this message]
2011-07-14  3:43     ` Christoph Hellwig
2011-07-14  4:03       ` Dave Chinner
2011-07-14 14:58         ` Christoph Hellwig
2011-07-14 17:04           ` Alex Elder

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1310581564.1998.38.camel@doink \
    --to=aelder@sgi.com \
    --cc=alal@google.com \
    --cc=hch@infradead.org \
    --cc=xfs@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.