From: Joe Perches <joe@perches.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Andy Whitcroft <apw@canonical.com>,
Kalle Valo <kvalo@qca.qualcomm.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] checkpatch.pl: Update $logFunctions
Date: Wed, 13 Jul 2011 16:41:56 -0700 [thread overview]
Message-ID: <1310600516.1662.43.camel@Joe-Laptop> (raw)
In-Reply-To: <20110713161640.83199c0b.akpm@linux-foundation.org>
On Wed, 2011-07-13 at 16:16 -0700, Andrew Morton wrote:
> On Wed, 13 Jul 2011 09:05:47 -0700
> Joe Perches <joe@perches.com> wrote:
> > Allow numbers in leading prefix.
> > Add logging functions with _once and _ratelimit.
> > Add <prefix>_printk.
> I look at this description wondering "hm, what does this do to
> checkpatch behaviour" and realize I have not a clue.
> Oh well, I'll trust you ;)
Not necessarily a good plan...
Perhaps this description instead:
[PATCH] checkpatch.pl: Allow more printk types (<prefix>_<level>) to be > 80 cols
Previous behavior allowed only alphabetic prefixes
like pr_info to exceed the 80 column line length limit.
ath6kl wants to add a digit into the prefix, so allow
numbers as well as digits in the <prefix>_<level> printks.
<prefix>_<level>_ratelimited and <prefix>_<level>_once
and WARN_RATELIMIT and WARN_ONCE may now exceed 80 cols.
Add missing <prefix>_printk type for completeness.
prev parent reply other threads:[~2011-07-13 23:41 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-13 16:05 [PATCH] checkpatch.pl: Update $logFunctions Joe Perches
2011-07-13 23:16 ` Andrew Morton
2011-07-13 23:41 ` Joe Perches [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1310600516.1662.43.camel@Joe-Laptop \
--to=joe@perches.com \
--cc=akpm@linux-foundation.org \
--cc=apw@canonical.com \
--cc=kvalo@qca.qualcomm.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.