From: Ben Hutchings <bhutchings@solarflare.com>
To: Flavio Leitner <fbl@redhat.com>
Cc: netdev <netdev@vger.kernel.org>
Subject: Re: preempting while holding rtnl_lock
Date: Fri, 15 Jul 2011 00:06:31 +0100 [thread overview]
Message-ID: <1310684791.8783.261.camel@localhost> (raw)
In-Reply-To: <20110714181502.4a5602aa@asterix.rh>
On Thu, 2011-07-14 at 18:15 -0300, Flavio Leitner wrote:
> Hi,
>
> I was reviewing driver sources and found that
> ethtool ops holds rtnl_lock() and there are few
> drivers (for example: tg3, bnx2) that use napi_disable()
> in this context.
[...]
> The msleep() above will preempt. I believe this is wrong.
[...]
> What am I missing?
The RTNL lock is a mutex so it's OK to sleep (but preferably not very
long) while holding it.
Ben.
--
Ben Hutchings, Senior Software Engineer, Solarflare
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.
prev parent reply other threads:[~2011-07-14 23:06 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-14 21:15 preempting while holding rtnl_lock Flavio Leitner
2011-07-14 23:06 ` Ben Hutchings [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1310684791.8783.261.camel@localhost \
--to=bhutchings@solarflare.com \
--cc=fbl@redhat.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.