All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas@monjalon.net>
To: Ali Alnubani <alialnu@nvidia.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>, Akhil Goyal <gakhil@marvell.com>
Subject: Re: [EXT] [PATCH] net: fix build with -Wpedantic
Date: Thu, 29 Sep 2022 09:20:43 +0200	[thread overview]
Message-ID: <13107122.y0N7aAr316@thomas> (raw)
In-Reply-To: <CO6PR18MB4484244ADD67B8337A52F99ED8579@CO6PR18MB4484.namprd18.prod.outlook.com>

29/09/2022 09:09, Akhil Goyal:
> > > > Adds the __extension__ attribute to resolve the following warning
> > > > with gcc 4.8.5 on CentOS 7:
> > > > lib/net/rte_macsec.h:38:2: error: type of bit-field 'short_length' is
> > > >   a GCC extension [-Werror=pedantic]
> > > >
> > > > Fixes: 0aaf097585a6 ("ethdev: add MACsec flow item")
> > > > Cc: gakhil@marvell.com
> > > >
> > > > Signed-off-by: Ali Alnubani <alialnu@nvidia.com>
> > > > ---
> > > >  lib/net/rte_macsec.h | 1 +
> > > >  1 file changed, 1 insertion(+)
> > > >
> > > > diff --git a/lib/net/rte_macsec.h b/lib/net/rte_macsec.h
> > > > index 9228ebd083..d0cd2f69ab 100644
> > > > --- a/lib/net/rte_macsec.h
> > > > +++ b/lib/net/rte_macsec.h
> > > > @@ -28,6 +28,7 @@ extern "C" {
> > > >  /**
> > > >   * MACsec Header (SecTAG)
> > > >   */
> > > > +__extension__
> > >
> > > RTE_STD_C11 ??
> > 
> > Replacing the __extension__ attribute with RTE_STD_C11 doesn't resolve the
> > build failure for me.
> 
> Ok, Thanks for the fix.
> 
> Acked-by: Akhil Goyal <gakhil@marvell.com>

Applied, thanks.



  reply	other threads:[~2022-09-29  7:20 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-29  6:50 [PATCH] net: fix build with -Wpedantic Ali Alnubani
2022-09-29  7:01 ` [EXT] " Akhil Goyal
2022-09-29  7:07   ` Ali Alnubani
2022-09-29  7:09     ` Akhil Goyal
2022-09-29  7:20       ` Thomas Monjalon [this message]
2022-09-29  7:09   ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=13107122.y0N7aAr316@thomas \
    --to=thomas@monjalon.net \
    --cc=alialnu@nvidia.com \
    --cc=dev@dpdk.org \
    --cc=gakhil@marvell.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.