From mboxrd@z Thu Jan  1 00:00:00 1970
From: George Dunlap <george.dunlap@citrix.com>
Subject: Re: [PATCH 1 of 4] hvm: remove cast from trace_var call
 for HVMOP_xentrace
Date: Fri, 15 Jul 2011 16:48:56 +0100
Message-ID: <1310744936.448.51.camel@elijah>
References: <patchbomb.1310744284@probook.site>
	<d0dcdddf5285eba0605a.1310744285@probook.site>
Mime-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xensource.com>
In-Reply-To: <d0dcdddf5285eba0605a.1310744285@probook.site>
List-Unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xensource.com>
List-Help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-Subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
Sender: xen-devel-bounces@lists.xensource.com
Errors-To: xen-devel-bounces@lists.xensource.com
To: Olaf Hering <olaf@aepfle.de>
Cc: George Dunlap <George.Dunlap@eu.citrix.com>, "xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>
List-Id: xen-devel@lists.xenproject.org

Acked-by: George Dunlap <george.dunlap@eu.citrix.com>

On Fri, 2011-07-15 at 16:38 +0100, Olaf Hering wrote:
> # HG changeset patch
> # User Olaf Hering <olaf@aepfle.de>
> # Date 1310741122 -7200
> # Node ID d0dcdddf5285eba0605a95dfda79b794803fa733
> # Parent  fbb448cf5cba5f441ad94f7783a0a1394fd638f9
> hvm: remove cast from trace_var call for HVMOP_xentrace
> 
> trace_var() takes a void pointer, casting is not needed.
> 
> Signed-off-by: Olaf Hering <olaf@aepfle.de>
> 
> diff -r fbb448cf5cba -r d0dcdddf5285 xen/arch/x86/hvm/hvm.c
> --- a/xen/arch/x86/hvm/hvm.c
> +++ b/xen/arch/x86/hvm/hvm.c
> @@ -3926,8 +3926,7 @@ long do_hvm_op(unsigned long op, XEN_GUE
>  
>          /* Cycles will be taken at the vmexit and vmenter */
>          trace_var(tr.event | TRC_GUEST, 0 /*!cycles*/,
> -                  tr.extra_bytes,
> -                  (unsigned char *)tr.extra);
> +                  tr.extra_bytes, tr.extra);
>          break;
>      }
>