All of lore.kernel.org
 help / color / mirror / Atom feed
From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: Patches and discussions about the oe-core layer
	<openembedded-core@lists.openembedded.org>
Cc: Koen Kooi <koen@openembedded.org>,
	Ihar Hrachyshka <ihar.hrachyshka@gmail.com>
Subject: Re: [PATCH v3 1/1] Fixed concurrency problem for ZIP packed recipes.
Date: Tue, 19 Jul 2011 18:04:07 +0100	[thread overview]
Message-ID: <1311095047.2344.17.camel@rex> (raw)
In-Reply-To: <7da7d67b36cfd010e56a401f51e20b81e20ddba0.1311008331.git.tom_rini@mentor.com>

On Mon, 2011-07-18 at 10:00 -0700, Tom Rini wrote:
> From: Ihar Hrachyshka <ihar.hrachyshka@gmail.com>
> 
> The problem occured when unzip-native is not yet staged, and ZIP
> archive unpacking already started resulting in failed do_unpack task.
> 
> (oe.dev has a NEED_UNZIP_FOR_UNPACK variable we did not bring over)
> 
> Signed-off-by: Ihar Hrachyshka <ihar.hrachyshka@gmail.com>
> Signed-off-by: Koen Kooi <koen@openembedded.org>
> Signed-off-by: Tom Rini <tom_rini@mentor.com>
> ---
>  meta/classes/base.bbclass |    8 ++++++++
>  1 files changed, 8 insertions(+), 0 deletions(-)
> 
> diff --git a/meta/classes/base.bbclass b/meta/classes/base.bbclass
> index 0c2c546..0347b90 100644
> --- a/meta/classes/base.bbclass
> +++ b/meta/classes/base.bbclass
> @@ -354,6 +354,14 @@ python () {
>          depends = depends + " xz-native:do_populate_sysroot"
>          bb.data.setVarFlag('do_unpack', 'depends', depends, d)
>  
> +    # unzip-native should already be staged before unpacking ZIP recipes
> +    src_uri = bb.data.getVar('SRC_URI', d, 1)
> +
> +    if ".zip" in src_uri:
> +        depends = bb.data.getVarFlag('do_unpack', 'depends', d) or ""
> +        depends = depends + " unzip-native:do_populate_sysroot"
> +        bb.data.setVarFlag('do_unpack', 'depends', depends, d)
> +
>      # 'multimachine' handling
>      mach_arch = bb.data.getVar('MACHINE_ARCH', d, 1)
>      pkg_arch = bb.data.getVar('PACKAGE_ARCH', d, 1)

I merged this with a tweak to use the already existing srcuri variable
after talking to Tom on irc.

Cheers,

Richard





      parent reply	other threads:[~2011-07-19 17:08 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-07-18 17:00 [PATCH v3 0/1] Add unzip DEPENDS for .zip SRC_URI files Tom Rini
2011-07-18 17:00 ` [PATCH v3 1/1] Fixed concurrency problem for ZIP packed recipes Tom Rini
2011-07-19 16:57   ` Richard Purdie
2011-07-19 17:04   ` Richard Purdie [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1311095047.2344.17.camel@rex \
    --to=richard.purdie@linuxfoundation.org \
    --cc=ihar.hrachyshka@gmail.com \
    --cc=koen@openembedded.org \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.