All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alex Elder <aelder@sgi.com>
To: Dave Chinner <david@fromorbit.com>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH 2/4] xfs: remove confusing ail cursor wrapper
Date: Tue, 19 Jul 2011 18:03:50 -0500	[thread overview]
Message-ID: <1311116630.1964.39.camel@doink> (raw)
In-Reply-To: <1310960419-9875-3-git-send-email-david@fromorbit.com>

On Mon, 2011-07-18 at 13:40 +1000, Dave Chinner wrote:
> From: Dave Chinner <dchinner@redhat.com>
> 
> xfs_trans_ail_cursor_set() doesn't set the cursor to the current log
> item, it sets it to the next item. There is already a function for
> doing this - xfs_trans_ail_cursor_next() - and the _set function is
> simply a two line wrapper.  Remove it and open code the setting of
> the cursor in the two locations that call it to remove the
> confusion.
> 
> Signed-off-by: Dave Chinner <dchinner@redhat.com>
> Reviewed-by: Christoph Hellwig <hch@lst.de>

I already reviewed this but I do see you did a tiny change
or two.  In any case, this (still) looks good.

Reviewed-by: Alex Elder <aelder@sgi.com>


_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

  reply	other threads:[~2011-07-19 23:03 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <1310960419-9875-1-git-send-email-david@fromorbit.com>
2011-07-18  3:40 ` [PATCH 1/4] xfs: use a cursor for bulk AIL insertion Dave Chinner
2011-07-19  2:01   ` Christoph Hellwig
2011-07-19  3:12     ` Dave Chinner
2011-07-19 23:03   ` Alex Elder
2011-07-19 23:36     ` Dave Chinner
2011-07-20  0:15       ` Christoph Hellwig
2011-07-20  0:21         ` Dave Chinner
2011-07-20 15:13         ` Alex Elder
2011-07-20 15:16       ` Alex Elder
2011-07-18  3:40 ` [PATCH 2/4] xfs: remove confusing ail cursor wrapper Dave Chinner
2011-07-19 23:03   ` Alex Elder [this message]
2011-07-18  3:40 ` [PATCH 3/4] xfs: convert AIL cursors to use struct list_head Dave Chinner
2011-07-19 23:03   ` Alex Elder
2011-07-19 23:43     ` Dave Chinner
2011-07-20 15:19       ` Alex Elder
2011-07-18  3:40 ` [PATCH 4/4] xfs: add size update tracepoint to IO completion Dave Chinner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1311116630.1964.39.camel@doink \
    --to=aelder@sgi.com \
    --cc=david@fromorbit.com \
    --cc=xfs@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.