From: Ben Hutchings <bhutchings@solarflare.com>
To: Kalle Valo <kvalo@qca.qualcomm.com>
Cc: netdev@vger.kernel.org, linux-wireless@vger.kernel.org
Subject: Re: [PATCH] ethtool: fix ethtool_get_regs() to work with zero length registers
Date: Wed, 20 Jul 2011 13:38:09 +0200 [thread overview]
Message-ID: <1311161889.1041.11.camel@localhost> (raw)
In-Reply-To: <20110720091850.32210.2059.stgit@localhost6.localdomain6>
On Wed, 2011-07-20 at 12:18 +0300, Kalle Valo wrote:
> cfg80211 exports zero length register size as it currently only uses
> struct ethtool_regs.version to export struct wiphy.hw_version.
[...]
The ethtool_regs::version field represents the version of the register
dump format. This may or may not relate to a hardware version.
If you don't actually provide a register dump then don't implement this
operation.
Ben.
--
Ben Hutchings, Senior Software Engineer, Solarflare
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.
next prev parent reply other threads:[~2011-07-20 11:38 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-20 9:18 [PATCH] ethtool: fix ethtool_get_regs() to work with zero length registers Kalle Valo
2011-07-20 9:18 ` Kalle Valo
2011-07-20 11:38 ` Ben Hutchings [this message]
2011-07-20 11:58 ` Kalle Valo
2011-07-20 11:58 ` Kalle Valo
2011-07-20 14:36 ` John W. Linville
2011-07-20 14:36 ` John W. Linville
2011-07-21 17:46 ` Ben Hutchings
2011-07-21 17:54 ` [PATCH net-2.6] ethtool: Allow zero-length register dumps again Ben Hutchings
2011-07-21 17:54 ` Ben Hutchings
2011-07-21 22:25 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1311161889.1041.11.camel@localhost \
--to=bhutchings@solarflare.com \
--cc=kvalo@qca.qualcomm.com \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.