From: Joe Perches <joe@perches.com>
To: Larry Finger <Larry.Finger@lwfinger.net>
Cc: Chaoming Li <chaoming_li@realsil.com.cn>,
"John W. Linville" <linville@tuxdriver.com>,
linux-wireless@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] rtlwifi: Convert printks to pr_<level>
Date: Wed, 20 Jul 2011 15:04:42 -0700 [thread overview]
Message-ID: <1311199482.1663.13.camel@Joe-Laptop> (raw)
In-Reply-To: <4E27048F.9090004@lwfinger.net>
On Wed, 2011-07-20 at 11:38 -0500, Larry Finger wrote:
> On 07/20/2011 10:51 AM, Joe Perches wrote:
> > Use the current logging styles.
> > Add pr_fmt where appropriate.
> > Remove now unnecessary prefixes from printks.
> > Convert hard coded prefix to __func__.
> > Add a missing "\n" to a format.
[]
> In general these look good, but why not define pr_fmt in rtlwifi/wifi.h. That
> header is used by every source file, and you only need the define once.
Because that's not the first #include in every file.
The #define pr_fmt has to be before anything that
includes kernel.h so it's safest/best to have it
be the first thing in the file.
At some point in the next year or so, all of the
uses of:
#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
should be removed and that should become the default.
cheers, Joe
next prev parent reply other threads:[~2011-07-20 22:04 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-20 15:51 [PATCH] rtlwifi: Convert printks to pr_<level> Joe Perches
2011-07-20 16:38 ` Larry Finger
2011-07-20 22:04 ` Joe Perches [this message]
2011-07-20 22:45 ` Larry Finger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1311199482.1663.13.camel@Joe-Laptop \
--to=joe@perches.com \
--cc=Larry.Finger@lwfinger.net \
--cc=chaoming_li@realsil.com.cn \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.