All of lore.kernel.org
 help / color / mirror / Atom feed
From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: Joshua Lock <josh@linux.intel.com>
Cc: bitbake-devel@lists.openembedded.org
Subject: Re: [RFC PATCH 0/1] Save the initial environment
Date: Thu, 21 Jul 2011 22:22:39 +0100	[thread overview]
Message-ID: <1311283359.2344.87.camel@rex> (raw)
In-Reply-To: <cover.1311028023.git.josh@linux.intel.com>

On Mon, 2011-07-18 at 15:33 -0700, Joshua Lock wrote:
> Both Chris' terminal work and my reparse command will benefit from a saved
> copy of the initial enviornment. The Python docs indicate that the os.environ
> map is captured when the os module is first imported
> http://docs.python.org/library/os.html#os.environ) so this patch adds a
> variable to the bb namespace (bb.initial_environ) that is an early copy of
> the environment.
> 
> I put the variable here so that a) it's easily accessible and b) we can take
> the copy pretty early on.
> 
> Any thoughts on this? Note the RFC prefix. :-)

Sorry I didn't reply earlier.

I'd really this the environment storage to be something we do explicitly
in bin/bitbake alongside:

    # Clear away any spurious environment variables. But don't wipe the
    # environment totally. This is necessary to ensure the correct operation
    # of the UIs (e.g. for DISPLAY, etc.)
    bb.utils.clean_environment()

I'd suggest we create a copy there, then pass it into cooker and its
cooker which actually stores the copy for future reference. We may then
need to find a way to get to that at the metadata level and from the UIs
but what shouldn't be too difficult.

Cheers,

Richard




  parent reply	other threads:[~2011-07-21 21:26 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-07-18 22:33 [RFC PATCH 0/1] Save the initial environment Joshua Lock
2011-07-18 22:33 ` [RFC PATCH 1/1] lib/bb: preserve a copy of the initial environment variables Joshua Lock
2011-07-21 21:22 ` Richard Purdie [this message]
2011-07-21 22:12   ` [RFC PATCH 0/1] Save the initial environment Joshua Lock

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1311283359.2344.87.camel@rex \
    --to=richard.purdie@linuxfoundation.org \
    --cc=bitbake-devel@lists.openembedded.org \
    --cc=josh@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.