From: Harald van Dijk <harald@gigawatt.nl>
To: dash@vger.kernel.org
Subject: Re: [PATCH] Avoid imaxdiv when only one of the results is wanted
Date: Tue, 26 Jul 2011 02:26:21 +0200 [thread overview]
Message-ID: <1311639981.15439.11.camel@linux> (raw)
In-Reply-To: <1311635376.10727.8.camel@linux>
On Tue, 2011-07-26 at 01:09 +0200, Harald van Dijk wrote:
> dash rather pointlessly calls imaxdiv, only to discard one of its
> results. The call was already made conditional a while back because some
> systems don't have imaxdiv, but the generated code for the version with
> imaxdiv and the one with / and % is identical (with GCC 4.6.1 or ICC
> 12.0.2, with -O0, -O2 or -Os), so it could just as well go entirely to
> clean up the code a little bit.
As I should have expected from those results, I messed up on the
comparisons. I still had an alternate definition of imaxdiv I was
testing with. The size actually decreases with the patch.
next prev parent reply other threads:[~2011-07-26 0:26 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-25 23:09 [PATCH] Avoid imaxdiv when only one of the results is wanted Harald van Dijk
2011-07-26 0:26 ` Harald van Dijk [this message]
2011-08-17 1:27 ` Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1311639981.15439.11.camel@linux \
--to=harald@gigawatt.nl \
--cc=dash@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.