All of lore.kernel.org
 help / color / mirror / Atom feed
From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: Joshua Lock <josh@linux.intel.com>
Cc: bitbake-devel@lists.openembedded.org
Subject: Re: [RFC PATCH 1/1] cooker: store a list of parsed configuration files
Date: Tue, 02 Aug 2011 14:37:39 +0100	[thread overview]
Message-ID: <1312292259.2344.593.camel@rex> (raw)
In-Reply-To: <a727b7256bcab11fb35c712a5920c1b8ed6f9425.1312240827.git.josh@linux.intel.com>

On Mon, 2011-08-01 at 16:22 -0700, Joshua Lock wrote:
> Signed-off-by: Joshua Lock <josh@linux.intel.com>
> ---
>  lib/bb/cooker.py                     |    3 +++
>  lib/bb/parse/parse_py/ConfHandler.py |    3 +++
>  2 files changed, 6 insertions(+), 0 deletions(-)
> 
> diff --git a/lib/bb/cooker.py b/lib/bb/cooker.py
> index 025dfe4..c7142e1 100644
> --- a/lib/bb/cooker.py
> +++ b/lib/bb/cooker.py
> @@ -772,6 +772,9 @@ class BBCooker:
>          for p in postfiles:
>              data = _parse(p, data)
>  
> +        self.configuration.parsed_configuration = (bb.data.getVar('PARSED_CONF', data) or '').split(':')
> +        bb.data.delVar('PARSED_CONF', data)
> +
>          # Handle any INHERITs and inherit the base class
>          bbclasses  = ["base"] + (data.getVar('INHERIT', True) or "").split()
>          for bbclass in bbclasses:
> diff --git a/lib/bb/parse/parse_py/ConfHandler.py b/lib/bb/parse/parse_py/ConfHandler.py
> index 102c0e9..22686b7 100644
> --- a/lib/bb/parse/parse_py/ConfHandler.py
> +++ b/lib/bb/parse/parse_py/ConfHandler.py
> @@ -103,6 +103,9 @@ def handle(fn, data, include):
>  
>      # DONE WITH PARSING... time to evaluate
>      bb.data.setVar('FILE', fn, data)
> +    conf_files = bb.data.getVar('PARSED_CONF', data) or ''
> +    bb.data.setVar('PARSED_CONF', "%s:%s" % (conf_files, abs_fn), data)
> +
>      statements.eval(data)
>      if oldfile:
>          bb.data.setVar('FILE', oldfile, data)

Hmm, this isn't particularly nice :/

At the very least call the variable __BB<something> to indicate its
internal.

Did you find and have a look at the internal __depends and
__base_depends variables?

Cheers,

Richard







  reply	other threads:[~2011-08-02 13:42 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-08-01 23:22 [RFC PATCH 0/1] Tracking parsed configuration files v2 Joshua Lock
2011-08-01 23:22 ` [RFC PATCH 1/1] cooker: store a list of parsed configuration files Joshua Lock
2011-08-02 13:37   ` Richard Purdie [this message]
2011-08-02 18:36     ` Joshua Lock

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1312292259.2344.593.camel@rex \
    --to=richard.purdie@linuxfoundation.org \
    --cc=bitbake-devel@lists.openembedded.org \
    --cc=josh@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.