All of lore.kernel.org
 help / color / mirror / Atom feed
From: Avi Kivity <avi@redhat.com>
To: Anthony Liguori <anthony@codemonkey.ws>, qemu-devel@nongnu.org
Cc: kvm@vger.kernel.org
Subject: [PATCH v2 02/38] vmsvga: don't remember pci BAR address in callback any more
Date: Wed,  3 Aug 2011 14:55:32 +0300	[thread overview]
Message-ID: <1312372568-5215-3-git-send-email-avi@redhat.com> (raw)
In-Reply-To: <1312372568-5215-1-git-send-email-avi@redhat.com>

We're going to remove the callback, so we can't use it to save the
address.  Use the pci API instead.

Reviewed-by: Richard Henderson <rth@twiddle.net>
Signed-off-by: Avi Kivity <avi@redhat.com>
---
 hw/vmware_vga.c |   12 ++++++------
 1 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/hw/vmware_vga.c b/hw/vmware_vga.c
index 354c221..190b005 100644
--- a/hw/vmware_vga.c
+++ b/hw/vmware_vga.c
@@ -52,8 +52,6 @@ struct vmsvga_state_s {
         int on;
     } cursor;
 
-    target_phys_addr_t vram_base;
-
     int index;
     int scratch_size;
     uint32_t *scratch;
@@ -761,8 +759,11 @@ static uint32_t vmsvga_value_read(void *opaque, uint32_t address)
     case SVGA_REG_BYTES_PER_LINE:
         return ((s->depth + 7) >> 3) * s->new_width;
 
-    case SVGA_REG_FB_START:
-        return s->vram_base;
+    case SVGA_REG_FB_START: {
+        struct pci_vmsvga_state_s *pci_vmsvga
+            = container_of(s, struct pci_vmsvga_state_s, chip);
+        return pci_get_bar_addr(&pci_vmsvga->card, 1);
+    }
 
     case SVGA_REG_FB_OFFSET:
         return 0x0;
@@ -1247,14 +1248,13 @@ static void pci_vmsvga_map_mem(PCIDevice *pci_dev, int region_num,
     struct vmsvga_state_s *s = &d->chip;
     ram_addr_t iomemtype;
 
-    s->vram_base = addr;
 #ifdef DIRECT_VRAM
     iomemtype = cpu_register_io_memory(vmsvga_vram_read,
                     vmsvga_vram_write, s, DEVICE_NATIVE_ENDIAN);
 #else
     iomemtype = s->vga.vram_offset | IO_MEM_RAM;
 #endif
-    cpu_register_physical_memory(s->vram_base, s->vga.vram_size,
+    cpu_register_physical_memory(addr, s->vga.vram_size,
                     iomemtype);
 
     s->vga.map_addr = addr;
-- 
1.7.5.3


WARNING: multiple messages have this Message-ID (diff)
From: Avi Kivity <avi@redhat.com>
To: Anthony Liguori <anthony@codemonkey.ws>, qemu-devel@nongnu.org
Cc: kvm@vger.kernel.org
Subject: [Qemu-devel] [PATCH v2 02/38] vmsvga: don't remember pci BAR address in callback any more
Date: Wed,  3 Aug 2011 14:55:32 +0300	[thread overview]
Message-ID: <1312372568-5215-3-git-send-email-avi@redhat.com> (raw)
In-Reply-To: <1312372568-5215-1-git-send-email-avi@redhat.com>

We're going to remove the callback, so we can't use it to save the
address.  Use the pci API instead.

Reviewed-by: Richard Henderson <rth@twiddle.net>
Signed-off-by: Avi Kivity <avi@redhat.com>
---
 hw/vmware_vga.c |   12 ++++++------
 1 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/hw/vmware_vga.c b/hw/vmware_vga.c
index 354c221..190b005 100644
--- a/hw/vmware_vga.c
+++ b/hw/vmware_vga.c
@@ -52,8 +52,6 @@ struct vmsvga_state_s {
         int on;
     } cursor;
 
-    target_phys_addr_t vram_base;
-
     int index;
     int scratch_size;
     uint32_t *scratch;
@@ -761,8 +759,11 @@ static uint32_t vmsvga_value_read(void *opaque, uint32_t address)
     case SVGA_REG_BYTES_PER_LINE:
         return ((s->depth + 7) >> 3) * s->new_width;
 
-    case SVGA_REG_FB_START:
-        return s->vram_base;
+    case SVGA_REG_FB_START: {
+        struct pci_vmsvga_state_s *pci_vmsvga
+            = container_of(s, struct pci_vmsvga_state_s, chip);
+        return pci_get_bar_addr(&pci_vmsvga->card, 1);
+    }
 
     case SVGA_REG_FB_OFFSET:
         return 0x0;
@@ -1247,14 +1248,13 @@ static void pci_vmsvga_map_mem(PCIDevice *pci_dev, int region_num,
     struct vmsvga_state_s *s = &d->chip;
     ram_addr_t iomemtype;
 
-    s->vram_base = addr;
 #ifdef DIRECT_VRAM
     iomemtype = cpu_register_io_memory(vmsvga_vram_read,
                     vmsvga_vram_write, s, DEVICE_NATIVE_ENDIAN);
 #else
     iomemtype = s->vga.vram_offset | IO_MEM_RAM;
 #endif
-    cpu_register_physical_memory(s->vram_base, s->vga.vram_size,
+    cpu_register_physical_memory(addr, s->vga.vram_size,
                     iomemtype);
 
     s->vga.map_addr = addr;
-- 
1.7.5.3

  parent reply	other threads:[~2011-08-03 11:56 UTC|newest]

Thread overview: 78+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-08-03 11:55 [PATCH v2 00/38] Memory API, batch 2: PCI devices Avi Kivity
2011-08-03 11:55 ` [Qemu-devel] " Avi Kivity
2011-08-03 11:55 ` [PATCH v2 01/38] pci: add API to get a BAR's mapped address Avi Kivity
2011-08-03 11:55   ` [Qemu-devel] " Avi Kivity
2011-08-03 11:55 ` Avi Kivity [this message]
2011-08-03 11:55   ` [Qemu-devel] [PATCH v2 02/38] vmsvga: don't remember pci BAR address in callback any more Avi Kivity
2011-08-03 11:55 ` [PATCH v2 03/38] vga: convert vga and its derivatives to the memory API Avi Kivity
2011-08-03 11:55   ` [Qemu-devel] " Avi Kivity
2011-08-03 11:55 ` [PATCH v2 04/38] cirrus: simplify mmio BAR access functions Avi Kivity
2011-08-03 11:55   ` [Qemu-devel] " Avi Kivity
2011-08-03 11:55 ` [PATCH v2 05/38] cirrus: simplify bitblt " Avi Kivity
2011-08-03 11:55   ` [Qemu-devel] " Avi Kivity
2011-08-03 11:55 ` [PATCH v2 06/38] cirrus: simplify vga window mmio " Avi Kivity
2011-08-03 11:55   ` [Qemu-devel] " Avi Kivity
2011-08-03 11:55 ` [PATCH v2 07/38] vga: " Avi Kivity
2011-08-03 11:55   ` [Qemu-devel] " Avi Kivity
2011-08-03 11:55 ` [PATCH v2 08/38] cirrus: simplify linear framebuffer " Avi Kivity
2011-08-03 11:55   ` [Qemu-devel] " Avi Kivity
2011-08-03 11:55 ` [PATCH v2 09/38] Integrate I/O memory regions into qemu Avi Kivity
2011-08-03 11:55   ` [Qemu-devel] " Avi Kivity
2011-08-03 11:55 ` [PATCH v2 10/38] pci: pass I/O address space to new PCI bus Avi Kivity
2011-08-03 11:55   ` [Qemu-devel] " Avi Kivity
2011-08-03 11:55 ` [PATCH v2 11/38] pci: allow I/O BARs to be registered with pci_register_bar_region() Avi Kivity
2011-08-03 11:55   ` [Qemu-devel] " Avi Kivity
2011-08-03 11:55 ` [PATCH v2 12/38] rtl8139: convert to memory API Avi Kivity
2011-08-03 11:55   ` [Qemu-devel] " Avi Kivity
2011-08-03 11:55 ` [PATCH v2 13/38] ac97: " Avi Kivity
2011-08-03 11:55   ` [Qemu-devel] " Avi Kivity
2011-08-03 11:55 ` [PATCH v2 14/38] e1000: " Avi Kivity
2011-08-03 11:55   ` [Qemu-devel] " Avi Kivity
2011-08-03 11:55 ` [PATCH v2 15/38] eepro100: " Avi Kivity
2011-08-03 11:55   ` [Qemu-devel] " Avi Kivity
2011-08-03 11:55 ` [PATCH v2 16/38] es1370: " Avi Kivity
2011-08-03 11:55   ` [Qemu-devel] " Avi Kivity
2011-08-03 11:55 ` [PATCH v2 17/38] ide: " Avi Kivity
2011-08-03 11:55   ` [Qemu-devel] " Avi Kivity
2011-08-03 11:55 ` [PATCH v2 18/38] ivshmem: " Avi Kivity
2011-08-03 11:55   ` [Qemu-devel] " Avi Kivity
2011-08-03 11:55 ` [PATCH v2 19/38] virtio-pci: " Avi Kivity
2011-08-03 11:55   ` [Qemu-devel] " Avi Kivity
2011-08-03 11:55 ` [PATCH v2 20/38] ahci: " Avi Kivity
2011-08-03 11:55   ` [Qemu-devel] " Avi Kivity
2011-08-03 11:55 ` [PATCH v2 21/38] intel-hda: " Avi Kivity
2011-08-03 11:55   ` [Qemu-devel] " Avi Kivity
2011-08-03 11:55 ` [PATCH v2 22/38] lsi53c895a: " Avi Kivity
2011-08-03 11:55   ` [Qemu-devel] " Avi Kivity
2011-08-03 11:55 ` [PATCH v2 23/38] ppc: " Avi Kivity
2011-08-03 11:55   ` [Qemu-devel] " Avi Kivity
2011-08-03 11:55 ` [PATCH v2 24/38] ne2000: " Avi Kivity
2011-08-03 11:55   ` [Qemu-devel] " Avi Kivity
2011-08-03 11:55 ` [PATCH v2 25/38] pcnet: " Avi Kivity
2011-08-03 11:55   ` [Qemu-devel] " Avi Kivity
2011-08-03 11:55 ` [PATCH v2 26/38] i6300esb: " Avi Kivity
2011-08-03 11:55   ` [Qemu-devel] " Avi Kivity
2011-08-03 11:55 ` [PATCH v2 27/38] isa-mmio: concert " Avi Kivity
2011-08-03 11:55   ` [Qemu-devel] " Avi Kivity
2011-08-03 11:55 ` [PATCH v2 28/38] sun4u: convert " Avi Kivity
2011-08-03 11:55   ` [Qemu-devel] " Avi Kivity
2011-08-03 11:55 ` [PATCH v2 29/38] ehci: " Avi Kivity
2011-08-03 11:55   ` [Qemu-devel] " Avi Kivity
2011-08-03 11:56 ` [PATCH v2 30/38] uhci: " Avi Kivity
2011-08-03 11:56   ` [Qemu-devel] " Avi Kivity
2011-08-03 11:56 ` [PATCH v2 31/38] xen-platform: " Avi Kivity
2011-08-03 11:56   ` [Qemu-devel] " Avi Kivity
2011-08-03 11:56 ` [PATCH v2 32/38] msix: " Avi Kivity
2011-08-03 11:56   ` [Qemu-devel] " Avi Kivity
2011-08-03 11:56 ` [PATCH v2 33/38] pci: remove pci_register_bar_simple() Avi Kivity
2011-08-03 11:56   ` [Qemu-devel] " Avi Kivity
2011-08-03 11:56 ` [PATCH v2 34/38] pci: convert pci rom to memory API Avi Kivity
2011-08-03 11:56   ` [Qemu-devel] " Avi Kivity
2011-08-03 11:56 ` [PATCH v2 35/38] pci: remove pci_register_bar() Avi Kivity
2011-08-03 11:56   ` [Qemu-devel] " Avi Kivity
2011-08-03 11:56 ` [PATCH v2 36/38] pci: fold BAR mapping function into its caller Avi Kivity
2011-08-03 11:56   ` [Qemu-devel] " Avi Kivity
2011-08-03 11:56 ` [PATCH v2 37/38] pci: rename pci_register_bar_region() to pci_register_bar() Avi Kivity
2011-08-03 11:56   ` [Qemu-devel] " Avi Kivity
2011-08-03 11:56 ` [PATCH v2 38/38] pci: remove support for pre memory API BARs Avi Kivity
2011-08-03 11:56   ` [Qemu-devel] " Avi Kivity

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1312372568-5215-3-git-send-email-avi@redhat.com \
    --to=avi@redhat.com \
    --cc=anthony@codemonkey.ws \
    --cc=kvm@vger.kernel.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.