From mboxrd@z Thu Jan 1 00:00:00 1970 From: Reinhard Meyer Date: Wed, 03 Aug 2011 15:49:26 +0000 Subject: [U-Boot] [PATCH] ARMv7: Add missing boards to MAKEALL In-Reply-To: <4E3960EA.9050406@aribaud.net> References: <1309966526-4401-1-git-send-email-dirk.behme@gmail.com> <4E395E7A.3020402@aribaud.net> <4E396017.4000303@aribaud.net> <4E3960EA.9050406@aribaud.net> Message-ID: <1312386566.31913.102.camel@ubuntu> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Dear Albert, > > After Reinhard's remark on boards.cfg vs MAKEALL, I may have accepted > > the patch a bit hastily. All of these boards are already in boards.cfg, > > and need not be in makeall IIUC. > > > > Thus, I am rolling back master one notch and will mark the patch as > > Supersedes (could not find a better match for "not needed any more") > > ... or not: here, adding this patch should have resulted in 12 more > boards built and 12 more boards failing to build, but actuelly 9 succeed. > > Reinhard, are you sure that boards that are in boards.cfg *and* in > MAKEALL will fail to build? This is not consistent with what I see here > with this patch. When at91sam9261 was still in MAKEALL, it did build clean (no errors or warnings), but the report at the end of a MAKEALL run had it in the list of boards with problems. After removing it from MAKEALL the effect was gone. I also noticed that it was not build twice, as one might expect. Maybe the effect was only there with an explicit "MAKEALL at91", I don't know - and its not worth to experiment there :) On any account, however, boards in boards.cfg are automatically included in a MAKEALL run. Best Regards, Reinhard