All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stephen Smalley <sds@tycho.nsa.gov>
To: Eric Paris <eparis@redhat.com>
Cc: Daniel J Walsh <dwalsh@redhat.com>, selinux@tycho.nsa.gov
Subject: Re: [PATCH 006/155] libselinux: do not check fcontext duplicates on use
Date: Thu, 04 Aug 2011 11:14:58 -0400	[thread overview]
Message-ID: <1312470898.20973.59.camel@moss-pluto> (raw)
In-Reply-To: <4E3AB236.4000404@redhat.com>

On Thu, 2011-08-04 at 10:52 -0400, Eric Paris wrote:
> I don't understand.  Before this patch rec->validating wasn't being used
> at all and we always checked for dups.  With this patch we actually pay
> attention to what the application set.  As it turns out
> restorecon/fixfiles don't set the flag, but semanage fcontext does, so
> this is actually a case where the programs were right but the underlying
> library was wrong.  I'm fixing the library to pay attention to the flag.
>  What am I missing?

Oops, I read the patch backwards.  Never mind.
Technically the library was correct in that the original meaning of
validate was to validate the contexts, but I suppose this fits with the
sense of it.

-- 
Stephen Smalley
National Security Agency


--
This message was distributed to subscribers of the selinux mailing list.
If you no longer wish to subscribe, send mail to majordomo@tycho.nsa.gov with
the words "unsubscribe selinux" without quotes as the message.

      reply	other threads:[~2011-08-04 15:14 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-08-03 20:48 [PATCH 006/155] libselinux: do not check fcontext duplicates on use Daniel J Walsh
2011-08-04 14:48 ` Stephen Smalley
2011-08-04 14:52   ` Eric Paris
2011-08-04 15:14     ` Stephen Smalley [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1312470898.20973.59.camel@moss-pluto \
    --to=sds@tycho.nsa.gov \
    --cc=dwalsh@redhat.com \
    --cc=eparis@redhat.com \
    --cc=selinux@tycho.nsa.gov \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.