All of lore.kernel.org
 help / color / mirror / Atom feed
From: Joshua Lock <josh@linux.intel.com>
To: Richard Purdie <richard.purdie@linuxfoundation.org>
Cc: bitbake-devel@lists.openembedded.org
Subject: Re: [PATCH 0/2] Store a list of parsed configuration files
Date: Fri, 05 Aug 2011 11:07:51 -0700	[thread overview]
Message-ID: <1312567676.2241.3.camel@scimitar> (raw)
In-Reply-To: <1312564373.14274.149.camel@rex>

On Fri, 2011-08-05 at 18:12 +0100, Richard Purdie wrote:
> On Tue, 2011-08-02 at 11:51 -0700, Joshua Lock wrote:
> > This series addresses Yocto #1246 "Configuration changes could be saved to a
> > file the cooker isn't using" by having the parser store a list of
> > configuration files it has parsed in the data object and then switching the
> > cooker to verify against this list that the found file was parsed before
> > emitting the ConfigFilePathFound event.
> > 
> > The following changes since commit 1009ca570a750a00b0e60afcc30ead070c7b310a:
> > 
> >   hob: remove temporary directory on program shutdown (2011-07-30 12:21:18 -0700)
> > 
> > are available in the git repository at:
> >   git://github.com/incandescant/bitbake configfiles
> >   https://github.com/incandescant/bitbake/tree/configfiles
> > 
> > Joshua Lock (2):
> >   bb/parse: track parsed configuration files in __BB_PARSED_CONF
> >   bb/cooker: only emit ConfigFilePathFound for files which were parsed
> 
> Am I right in thinking this series is now superseded by the tweak to
> include the information in __base_depends?

That's right. The only reason I haven't sent that patch out yet is
because I'm in two minds about which is the cleanest way.

Because __base_depends a) contains more than just .conf files and b)
gets renamed I'm thinking the cleanest thing to do would be to iterate
__depends before the call to renameVar, pull out all conf files and
store them in self.configuration.config_files (or similar).

I wasn't sure adding an extra list to the configuration object would be
appreciated though...

Cheers,
Joshua
-- 
Joshua Lock
        Yocto Project "Johannes factotum"
        Intel Open Source Technology Centre




  reply	other threads:[~2011-08-05 18:12 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-08-02 18:51 [PATCH 0/2] Store a list of parsed configuration files Joshua Lock
2011-08-02 18:51 ` [PATCH 1/2] bb/parse: track parsed configuration files in __BB_PARSED_CONF Joshua Lock
2011-08-02 18:51 ` [PATCH 2/2] bb/cooker: only emit ConfigFilePathFound for files which were parsed Joshua Lock
2011-08-05 17:12 ` [PATCH 0/2] Store a list of parsed configuration files Richard Purdie
2011-08-05 18:07   ` Joshua Lock [this message]
2011-08-08 17:07     ` Richard Purdie

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1312567676.2241.3.camel@scimitar \
    --to=josh@linux.intel.com \
    --cc=bitbake-devel@lists.openembedded.org \
    --cc=richard.purdie@linuxfoundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.