From: Johannes Berg <johannes@sipsolutions.net>
To: Guy Eilam <guy@wizery.com>
Cc: linux-wireless@vger.kernel.org
Subject: Re: [PATCH 1/2] mac80211: refactor sta_info_insert_rcu to 3 main stages
Date: Mon, 08 Aug 2011 15:35:57 +0200 [thread overview]
Message-ID: <1312810557.4372.34.camel@jlt3.sipsolutions.net> (raw)
In-Reply-To: <1311715772-8855-1-git-send-email-guy@wizery.com> (sfid-20110726_233144_501539_6CB55590)
Just a cursory look, I'll send a more detailed review later, but I
wanted to ask John to not merge this for now;
> +static int sta_info_insert_adhoc(struct sta_info *sta) __acquires(RCU)
_ibss would be preferred
> +static int sta_info_insert_mgd(struct sta_info *sta) __acquires(RCU)
_mgd is terribly misleading, this will be done for all modes other than
IBSS.
johannes
next prev parent reply other threads:[~2011-08-08 13:35 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-26 21:29 [PATCH 1/2] mac80211: refactor sta_info_insert_rcu to 3 main stages Guy Eilam
2011-07-26 21:29 ` [PATCH 2/2] mac80211: fix race condition between assoc_done and first EAP packet Guy Eilam
2011-08-08 13:35 ` Johannes Berg [this message]
2011-08-09 9:02 ` [PATCH 1/2] mac80211: refactor sta_info_insert_rcu to 3 main stages Guy Eilam
2011-08-09 12:20 ` Johannes Berg
2011-08-16 17:11 ` Guy Eilam
2011-08-16 17:24 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1312810557.4372.34.camel@jlt3.sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=guy@wizery.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.