All of lore.kernel.org
 help / color / mirror / Atom feed
From: Liam Girdwood <lrg@kernel.org>
To: MyungJoo Ham <myungjoo.ham@samsung.com>
Cc: Axel Lin <axel.lin@gmail.com>,
	linux-kernel@vger.kernel.org,
	Mark Brown <broonie@opensource.wolfsonmicro.com>,
	myungjoo.ham@gmail.com, Liam Girdwood <lrg@ti.com>
Subject: Re: [PATCH] regulator: max8952: removed unused mutex.
Date: Mon, 08 Aug 2011 17:40:20 +0100	[thread overview]
Message-ID: <1312821620.3316.5.camel@odin> (raw)
In-Reply-To: <1312333083-22615-1-git-send-email-myungjoo.ham@samsung.com>

On Wed, 2011-08-03 at 09:58 +0900, MyungJoo Ham wrote:
> This patch removes a mutex that is never used in the driver.
> 
> Reported-by: Axel Lin
> Signed-off-by: MyungJoo Ham <myungjoo.ham@samsung.com>
> ---
>  drivers/regulator/max8952.c |    3 ---
>  1 files changed, 0 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/regulator/max8952.c b/drivers/regulator/max8952.c
> index daff7fd..2fa8a81 100644
> --- a/drivers/regulator/max8952.c
> +++ b/drivers/regulator/max8952.c
> @@ -26,7 +26,6 @@
>  #include <linux/platform_device.h>
>  #include <linux/regulator/driver.h>
>  #include <linux/regulator/max8952.h>
> -#include <linux/mutex.h>
>  #include <linux/gpio.h>
>  #include <linux/io.h>
>  #include <linux/slab.h>
> @@ -47,7 +46,6 @@ enum {
>  struct max8952_data {
>  	struct i2c_client	*client;
>  	struct device		*dev;
> -	struct mutex		mutex;
>  	struct max8952_platform_data *pdata;
>  	struct regulator_dev	*rdev;
>  
> @@ -208,7 +206,6 @@ static int __devinit max8952_pmic_probe(struct i2c_client *client,
>  	max8952->client = client;
>  	max8952->dev = &client->dev;
>  	max8952->pdata = pdata;
> -	mutex_init(&max8952->mutex);
>  
>  	max8952->rdev = regulator_register(&regulator, max8952->dev,
>  			&pdata->reg_data, max8952);

Applied.

Thanks

Liam


      parent reply	other threads:[~2011-08-08 16:40 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-08-02 12:16 regulator: max8952 init a mutex but never use it Axel Lin
2011-08-02 13:41 ` Liam Girdwood
2011-08-03  0:58   ` [PATCH] regulator: max8952: removed unused mutex MyungJoo Ham
2011-08-03  4:38     ` Mark Brown
2011-08-08 16:40     ` Liam Girdwood [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1312821620.3316.5.camel@odin \
    --to=lrg@kernel.org \
    --cc=axel.lin@gmail.com \
    --cc=broonie@opensource.wolfsonmicro.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lrg@ti.com \
    --cc=myungjoo.ham@gmail.com \
    --cc=myungjoo.ham@samsung.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.