From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sasha Levin Subject: [PATCH] kvm tools: Change method of retrieving process name Date: Tue, 9 Aug 2011 13:17:39 +0300 Message-ID: <1312885059-842-1-git-send-email-levinsasha928@gmail.com> Cc: psuriset@linux.vnet.ibm.com, mingo@elte.hu, asias.hejun@gmail.com, prasadjoshi124@gmail.com, gorcunov@gmail.com, kvm@vger.kernel.org, Sasha Levin To: penberg@kernel.org Return-path: Received: from mail-wy0-f174.google.com ([74.125.82.174]:42842 "EHLO mail-wy0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753114Ab1HIKSG (ORCPT ); Tue, 9 Aug 2011 06:18:06 -0400 Received: by wyg24 with SMTP id 24so245829wyg.19 for ; Tue, 09 Aug 2011 03:18:05 -0700 (PDT) Sender: kvm-owner@vger.kernel.org List-ID: This patch changes './kvm list' to retrieve process name from '/proc//stat' instead of '/proc//comm' as it appears the latter does not exist by default on several systems. Reported-by: pradeep Signed-off-by: Sasha Levin --- tools/kvm/builtin-list.c | 21 ++++++++++++++------- 1 files changed, 14 insertions(+), 7 deletions(-) diff --git a/tools/kvm/builtin-list.c b/tools/kvm/builtin-list.c index 2d37ecb..89a0465 100644 --- a/tools/kvm/builtin-list.c +++ b/tools/kvm/builtin-list.c @@ -13,25 +13,32 @@ static void print_guest(const char *name, int pid) { char proc_name[PATH_MAX]; - char comm[sizeof(PROCESS_NAME)]; - int fd; + char *comm = NULL; + FILE *fd; - sprintf(proc_name, "/proc/%d/comm", pid); - fd = open(proc_name, O_RDONLY); - if (fd <= 0) + sprintf(proc_name, "/proc/%d/stat", pid); + fd = fopen(proc_name, "r"); + if (fd == NULL) goto cleanup; - if (read(fd, comm, sizeof(PROCESS_NAME)) == 0) + if (fscanf(fd, "%*u (%as)", &comm) == 0) goto cleanup; if (strncmp(comm, PROCESS_NAME, strlen(PROCESS_NAME))) goto cleanup; printf("%s (PID: %d)\n", name, pid); - close(fd); + free(comm); + + fclose(fd); return; cleanup: + if (fd) + fclose(fd); + if (comm) + free(comm); + kvm__remove_pidfile(name); } -- 1.7.6